diff options
| author | dglazkov@chromium.org <dglazkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-05 21:28:51 +0000 |
|---|---|---|
| committer | dglazkov@chromium.org <dglazkov@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-08-05 21:28:51 +0000 |
| commit | 991cf3c582cf9c8c4ee877349e1cd35ac2b838e9 (patch) | |
| tree | 688590b7eda16786d4c915baeef7a68b05b22e9a /chrome/browser/visitedlink_unittest.cc | |
| parent | d59baf73fcb717fab2bbab2d9851bc9da3d5745c (diff) | |
| download | chromium_src-991cf3c582cf9c8c4ee877349e1cd35ac2b838e9.zip chromium_src-991cf3c582cf9c8c4ee877349e1cd35ac2b838e9.tar.gz chromium_src-991cf3c582cf9c8c4ee877349e1cd35ac2b838e9.tar.bz2 | |
Ensure that we never call into WebCore::Page static methods when Page constructor hasn't been called.
This is a top crash for Mac right now. The crash occurs because the static table of all pages in the renderer is initialized
in WebCore:: Page constructor, and if we attempt to access this table before the Page was created (i.e. before WebView::Create is called),
we get into a crashy situation. I am really not sure how to reproduce this, but I can defend against the situation.
BUG=17555
R=darin
TEST=unable to repro, speculative fix.
Review URL: http://codereview.chromium.org/159887
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22540 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/visitedlink_unittest.cc')
| -rw-r--r-- | chrome/browser/visitedlink_unittest.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/chrome/browser/visitedlink_unittest.cc b/chrome/browser/visitedlink_unittest.cc index 16ee644..d6735ae 100644 --- a/chrome/browser/visitedlink_unittest.cc +++ b/chrome/browser/visitedlink_unittest.cc @@ -565,6 +565,7 @@ class VisitedLinkEventsTest : public RenderViewHostTestHarness { rvh_factory_.set_render_process_host_factory(&vc_rph_factory_); profile_.reset(new VisitCountingProfile(event_listener_.get())); RenderViewHostTestHarness::SetUp(); + rvh()->CreateRenderView(); } VisitCountingProfile* profile() const { |