diff options
author | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-28 20:58:48 +0000 |
---|---|---|
committer | jhawkins@chromium.org <jhawkins@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-28 20:58:48 +0000 |
commit | 7a8edafc2e81f88a1f8e699f1bb17662b23cb6af (patch) | |
tree | bb0cfe6a38502a914e6fbcc80338b05095e8d6ee /chrome/browser/webdata/web_database_migration_unittest.cc | |
parent | 8faf9ba57ca3abbc5dd35d047097aed237d02d5e (diff) | |
download | chromium_src-7a8edafc2e81f88a1f8e699f1bb17662b23cb6af.zip chromium_src-7a8edafc2e81f88a1f8e699f1bb17662b23cb6af.tar.gz chromium_src-7a8edafc2e81f88a1f8e699f1bb17662b23cb6af.tar.bz2 |
Cleanup: Convert ASCIIToUTF16("") to string16().
Inspired by r111713.
BUG=none
TEST=none
R=gbillock@chromium.org
Review URL: http://codereview.chromium.org/8687002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser/webdata/web_database_migration_unittest.cc')
-rw-r--r-- | chrome/browser/webdata/web_database_migration_unittest.cc | 36 |
1 files changed, 18 insertions, 18 deletions
diff --git a/chrome/browser/webdata/web_database_migration_unittest.cc b/chrome/browser/webdata/web_database_migration_unittest.cc index 3969e00..ef5dbd1 100644 --- a/chrome/browser/webdata/web_database_migration_unittest.cc +++ b/chrome/browser/webdata/web_database_migration_unittest.cc @@ -1044,9 +1044,9 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { // Dave Smith. ASSERT_TRUE(s1.Step()); EXPECT_EQ("4C74A9D8-7EEE-423E-F9C2-E7FA70ED1396", s1.ColumnString(0)); - EXPECT_EQ(ASCIIToUTF16(""), s1.ColumnString16(1)); + EXPECT_EQ(string16(), s1.ColumnString16(1)); EXPECT_EQ(ASCIIToUTF16("2 Main Street"), s1.ColumnString16(2)); - EXPECT_EQ(ASCIIToUTF16(""), s1.ColumnString16(3)); + EXPECT_EQ(string16(), s1.ColumnString16(3)); EXPECT_EQ(ASCIIToUTF16("Los Altos"), s1.ColumnString16(4)); EXPECT_EQ(ASCIIToUTF16("CA"), s1.ColumnString16(5)); EXPECT_EQ(ASCIIToUTF16("94022"), s1.ColumnString16(6)); @@ -1056,9 +1056,9 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { // Dave Smith (Part 2). ASSERT_TRUE(s1.Step()); EXPECT_EQ("722DF5C4-F74A-294A-46F0-31FFDED0D635", s1.ColumnString(0)); - EXPECT_EQ(ASCIIToUTF16(""), s1.ColumnString16(1)); + EXPECT_EQ(string16(), s1.ColumnString16(1)); EXPECT_EQ(ASCIIToUTF16("2 Main St"), s1.ColumnString16(2)); - EXPECT_EQ(ASCIIToUTF16(""), s1.ColumnString16(3)); + EXPECT_EQ(string16(), s1.ColumnString16(3)); EXPECT_EQ(ASCIIToUTF16("Los Altos"), s1.ColumnString16(4)); EXPECT_EQ(ASCIIToUTF16("CA"), s1.ColumnString16(5)); EXPECT_EQ(ASCIIToUTF16("94022"), s1.ColumnString16(6)); @@ -1071,9 +1071,9 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { // 3 Main St. ASSERT_TRUE(s1.Step()); EXPECT_EQ("9E5FE298-62C7-83DF-6293-381BC589183F", s1.ColumnString(0)); - EXPECT_EQ(ASCIIToUTF16(""), s1.ColumnString16(1)); + EXPECT_EQ(string16(), s1.ColumnString16(1)); EXPECT_EQ(ASCIIToUTF16("3 Main St"), s1.ColumnString16(2)); - EXPECT_EQ(ASCIIToUTF16(""), s1.ColumnString16(3)); + EXPECT_EQ(string16(), s1.ColumnString16(3)); EXPECT_EQ(ASCIIToUTF16("Los Altos"), s1.ColumnString16(4)); EXPECT_EQ(ASCIIToUTF16("CA"), s1.ColumnString16(5)); EXPECT_EQ(ASCIIToUTF16("94022"), s1.ColumnString16(6)); @@ -1092,7 +1092,7 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { ASSERT_TRUE(s2.Step()); EXPECT_EQ("00580526-FF81-EE2A-0546-1AC593A32E2F", s2.ColumnString(0)); EXPECT_EQ(ASCIIToUTF16("John"), s2.ColumnString16(1)); - EXPECT_EQ(ASCIIToUTF16(""), s2.ColumnString16(2)); + EXPECT_EQ(string16(), s2.ColumnString16(2)); EXPECT_EQ(ASCIIToUTF16("Doe"), s2.ColumnString16(3)); // John P. Doe. Note same guid as above due to merging of multi-valued @@ -1107,14 +1107,14 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { ASSERT_TRUE(s2.Step()); EXPECT_EQ("4C74A9D8-7EEE-423E-F9C2-E7FA70ED1396", s2.ColumnString(0)); EXPECT_EQ(ASCIIToUTF16("Dave"), s2.ColumnString16(1)); - EXPECT_EQ(ASCIIToUTF16(""), s2.ColumnString16(2)); + EXPECT_EQ(string16(), s2.ColumnString16(2)); EXPECT_EQ(ASCIIToUTF16("Smith"), s2.ColumnString16(3)); // Dave Smith (Part 2). ASSERT_TRUE(s2.Step()); EXPECT_EQ("722DF5C4-F74A-294A-46F0-31FFDED0D635", s2.ColumnString(0)); EXPECT_EQ(ASCIIToUTF16("Dave"), s2.ColumnString16(1)); - EXPECT_EQ(ASCIIToUTF16(""), s2.ColumnString16(2)); + EXPECT_EQ(string16(), s2.ColumnString16(2)); EXPECT_EQ(ASCIIToUTF16("Smith"), s2.ColumnString16(3)); // Alfred E Newman. @@ -1123,9 +1123,9 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { // 3 Main St. ASSERT_TRUE(s2.Step()); EXPECT_EQ("9E5FE298-62C7-83DF-6293-381BC589183F", s2.ColumnString(0)); - EXPECT_EQ(ASCIIToUTF16(""), s2.ColumnString16(1)); - EXPECT_EQ(ASCIIToUTF16(""), s2.ColumnString16(2)); - EXPECT_EQ(ASCIIToUTF16(""), s2.ColumnString16(3)); + EXPECT_EQ(string16(), s2.ColumnString16(1)); + EXPECT_EQ(string16(), s2.ColumnString16(2)); + EXPECT_EQ(string16(), s2.ColumnString16(3)); // Should be all. EXPECT_FALSE(s2.Step()); @@ -1147,12 +1147,12 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { // 2 Main Street. ASSERT_TRUE(s3.Step()); EXPECT_EQ("4C74A9D8-7EEE-423E-F9C2-E7FA70ED1396", s3.ColumnString(0)); - EXPECT_EQ(ASCIIToUTF16(""), s3.ColumnString16(1)); + EXPECT_EQ(string16(), s3.ColumnString16(1)); // 2 Main St. ASSERT_TRUE(s3.Step()); EXPECT_EQ("722DF5C4-F74A-294A-46F0-31FFDED0D635", s3.ColumnString(0)); - EXPECT_EQ(ASCIIToUTF16(""), s3.ColumnString16(1)); + EXPECT_EQ(string16(), s3.ColumnString16(1)); // Alfred E Newman. // Gets culled during migration from 35 to 36 due to incomplete address. @@ -1160,7 +1160,7 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { // 3 Main St. ASSERT_TRUE(s3.Step()); EXPECT_EQ("9E5FE298-62C7-83DF-6293-381BC589183F", s3.ColumnString(0)); - EXPECT_EQ(ASCIIToUTF16(""), s3.ColumnString16(1)); + EXPECT_EQ(string16(), s3.ColumnString16(1)); // Should be all. EXPECT_FALSE(s3.Step()); @@ -1191,7 +1191,7 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { ASSERT_TRUE(s4.Step()); EXPECT_EQ("4C74A9D8-7EEE-423E-F9C2-E7FA70ED1396", s4.ColumnString(0)); EXPECT_EQ(0, s4.ColumnInt(1)); // 0 means phone. - EXPECT_EQ(ASCIIToUTF16(""), s4.ColumnString16(2)); + EXPECT_EQ(string16(), s4.ColumnString16(2)); // 2 Main Street fax. // Gets culled after fax type removed. @@ -1200,7 +1200,7 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { ASSERT_TRUE(s4.Step()); EXPECT_EQ("722DF5C4-F74A-294A-46F0-31FFDED0D635", s4.ColumnString(0)); EXPECT_EQ(0, s4.ColumnInt(1)); // 0 means phone. - EXPECT_EQ(ASCIIToUTF16(""), s4.ColumnString16(2)); + EXPECT_EQ(string16(), s4.ColumnString16(2)); // 2 Main St fax. // Gets culled after fax type removed. @@ -1211,7 +1211,7 @@ TEST_F(WebDatabaseMigrationTest, MigrateVersion32ToCurrent) { ASSERT_TRUE(s4.Step()); EXPECT_EQ("9E5FE298-62C7-83DF-6293-381BC589183F", s4.ColumnString(0)); EXPECT_EQ(0, s4.ColumnInt(1)); // 0 means phone. - EXPECT_EQ(ASCIIToUTF16(""), s4.ColumnString16(2)); + EXPECT_EQ(string16(), s4.ColumnString16(2)); // 2 Main St fax. // Gets culled after fax type removed. |