diff options
| author | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-16 19:53:00 +0000 |
|---|---|---|
| committer | xji@chromium.org <xji@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-01-16 19:53:00 +0000 |
| commit | 1a3f426f71ee35848e94356dd6bdd423aaff5608 (patch) | |
| tree | 2fe68d926194ad16627b6db0f7836a34b4ceb841 /chrome/browser | |
| parent | 650e4d7f574f4f122e122f11142f53133e467b6d (diff) | |
| download | chromium_src-1a3f426f71ee35848e94356dd6bdd423aaff5608.zip chromium_src-1a3f426f71ee35848e94356dd6bdd423aaff5608.tar.gz chromium_src-1a3f426f71ee35848e94356dd6bdd423aaff5608.tar.bz2 | |
This change list fix issues 6093 [settings] bad directionality for gears button
(http://crbug.com/6093).
The directionality of gears button is already fixed.
This CL fixes the wrong location of ":".
It adds RLM at the end of string "Google Gears:" for Hebrew and Arabic Chrome,
so that the ":" in "Google Gears:" in Hebrew is displayed leftmost instead of
rightmost.
Test:
1) open chrome, Hebrew UI
2) option -> under the hood -> google gears
Without the fix, the name appears as "Google Gears:".
With the fix, the name appears as ":Google Gears".
Review URL: http://codereview.chromium.org/18279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8205 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/views/options/advanced_contents_view.cc | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/chrome/browser/views/options/advanced_contents_view.cc b/chrome/browser/views/options/advanced_contents_view.cc index d3860e6..c73b858 100644 --- a/chrome/browser/views/options/advanced_contents_view.cc +++ b/chrome/browser/views/options/advanced_contents_view.cc @@ -685,8 +685,15 @@ void WebContentSection::InitControlLayout() { l10n_util::GetString(IDS_OPTIONS_SHOWPOPUPBLOCKEDNOTIFICATION)); popup_blocked_notification_checkbox_->SetListener(this); - gears_label_ = new views::Label( - l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME)); + if (l10n_util::GetTextDirection() == l10n_util::LEFT_TO_RIGHT) { + gears_label_ = new views::Label( + l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME)); + } else { + // Add an RTL mark so that + // ":" in "Google Gears:" in Hebrew Chrome is displayed left-most. + gears_label_ = new views::Label(l10n_util::GetString( + IDS_OPTIONS_GEARSSETTINGS_GROUP_NAME) + l10n_util::kRightToLeftMark); + } gears_settings_button_ = new views::NativeButton( l10n_util::GetString(IDS_OPTIONS_GEARSSETTINGS_CONFIGUREGEARS_BUTTON)); gears_settings_button_->SetListener(this); |