summaryrefslogtreecommitdiffstats
path: root/chrome/browser
diff options
context:
space:
mode:
authorpkasting <pkasting@chromium.org>2015-04-07 21:42:12 -0700
committerCommit bot <commit-bot@chromium.org>2015-04-08 04:42:40 +0000
commit379234c28f3856045a67af657296d6911156bbff (patch)
treec0d7f0cab2fb491b97efec10fc8c444c49fc1ade /chrome/browser
parent8f0f3b63b8fd45d72ab957bdc12c714899199a72 (diff)
downloadchromium_src-379234c28f3856045a67af657296d6911156bbff.zip
chromium_src-379234c28f3856045a67af657296d6911156bbff.tar.gz
chromium_src-379234c28f3856045a67af657296d6911156bbff.tar.bz2
Remove unnecessary instrumentation for several jank bugs.
BUG=437890,436671,455423,424386,436634,422516 TEST=none TBR=jochen,cbentzel,jyasskin Review URL: https://codereview.chromium.org/1062413002 Cr-Commit-Position: refs/heads/master@{#324185}
Diffstat (limited to 'chrome/browser')
-rw-r--r--chrome/browser/devtools/device/port_forwarding_controller.cc5
-rw-r--r--chrome/browser/download/download_resource_throttle.cc6
-rw-r--r--chrome/browser/net/chrome_url_request_context_getter.cc29
-rw-r--r--chrome/browser/net/predictor.cc91
-rw-r--r--chrome/browser/profiles/off_the_record_profile_io_data.cc6
-rw-r--r--chrome/browser/profiles/profile_impl_io_data.cc72
-rw-r--r--chrome/browser/profiles/profile_io_data.cc25
-rw-r--r--chrome/browser/task_manager/browser_process_resource_provider.cc30
-rw-r--r--chrome/browser/task_manager/task_manager.cc47
9 files changed, 44 insertions, 267 deletions
diff --git a/chrome/browser/devtools/device/port_forwarding_controller.cc b/chrome/browser/devtools/device/port_forwarding_controller.cc
index 7777672..cd7dc34 100644
--- a/chrome/browser/devtools/device/port_forwarding_controller.cc
+++ b/chrome/browser/devtools/device/port_forwarding_controller.cc
@@ -11,7 +11,6 @@
#include "base/memory/singleton.h"
#include "base/message_loop/message_loop.h"
#include "base/prefs/pref_service.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
#include "base/strings/stringprintf.h"
@@ -89,10 +88,6 @@ class SocketTunnel : public base::NonThreadSafe {
}
void OnResolved(int result) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436634 SocketTunnel::OnResolved"));
-
if (result < 0) {
SelfDestruct();
return;
diff --git a/chrome/browser/download/download_resource_throttle.cc b/chrome/browser/download/download_resource_throttle.cc
index e613ae9..a8e2afa 100644
--- a/chrome/browser/download/download_resource_throttle.cc
+++ b/chrome/browser/download/download_resource_throttle.cc
@@ -5,7 +5,6 @@
#include "chrome/browser/download/download_resource_throttle.h"
#include "base/bind.h"
-#include "base/profiler/scoped_tracker.h"
#include "chrome/browser/download/download_stats.h"
#include "content/public/browser/resource_controller.h"
@@ -41,11 +40,6 @@ void DownloadResourceThrottle::WillRedirectRequest(
}
void DownloadResourceThrottle::WillProcessResponse(bool* defer) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/422516 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "422516 DownloadResourceThrottle::WillProcessResponse"));
-
WillDownload(defer);
}
diff --git a/chrome/browser/net/chrome_url_request_context_getter.cc b/chrome/browser/net/chrome_url_request_context_getter.cc
index 81f7519..ab3ed5d 100644
--- a/chrome/browser/net/chrome_url_request_context_getter.cc
+++ b/chrome/browser/net/chrome_url_request_context_getter.cc
@@ -8,7 +8,6 @@
#include "base/compiler_specific.h"
#include "base/message_loop/message_loop.h"
#include "base/message_loop/message_loop_proxy.h"
-#include "base/profiler/scoped_tracker.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/io_thread.h"
#include "chrome/browser/profiles/profile.h"
@@ -50,10 +49,6 @@ class FactoryForMain : public ChromeURLRequestContextFactory {
}
net::URLRequestContext* Create() override {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 FactoryForMain::Create"));
-
profile_io_data_->Init(&protocol_handlers_, request_interceptors_.Pass());
return profile_io_data_->GetMainRequestContext();
}
@@ -71,11 +66,6 @@ class FactoryForExtensions : public ChromeURLRequestContextFactory {
: profile_io_data_(profile_io_data) {}
net::URLRequestContext* Create() override {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 FactoryForExtensions::Create"));
-
return profile_io_data_->GetExtensionsRequestContext();
}
@@ -103,11 +93,6 @@ class FactoryForIsolatedApp : public ChromeURLRequestContextFactory {
}
net::URLRequestContext* Create() override {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 FactoryForIsolatedApp::Create"));
-
// We will copy most of the state from the main request context.
//
// Note that this factory is one-shot. After Create() is called once, the
@@ -145,11 +130,6 @@ class FactoryForIsolatedMedia : public ChromeURLRequestContextFactory {
app_context_getter_(app_context) {}
net::URLRequestContext* Create() override {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 FactoryForIsolatedMedia::Create"));
-
// We will copy most of the state from the corresopnding app's
// request context. We expect to have the same lifetime as
// the associated |app_context_getter_| so we can just reuse
@@ -174,10 +154,6 @@ class FactoryForMedia : public ChromeURLRequestContextFactory {
}
net::URLRequestContext* Create() override {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 FactoryForMedia::Create"));
-
return profile_io_data_->GetMediaRequestContext();
}
@@ -203,11 +179,6 @@ ChromeURLRequestContextGetter::~ChromeURLRequestContextGetter() {}
// Lazily create a URLRequestContext using our factory.
net::URLRequestContext*
ChromeURLRequestContextGetter::GetURLRequestContext() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ChromeURLRequestContextGetter::GetURLRequestContext"));
-
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
if (factory_.get()) {
diff --git a/chrome/browser/net/predictor.cc b/chrome/browser/net/predictor.cc
index a64be9e..b135b2f 100644
--- a/chrome/browser/net/predictor.cc
+++ b/chrome/browser/net/predictor.cc
@@ -125,11 +125,6 @@ class Predictor::LookupRequest {
private:
void OnLookupFinished(int result) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436634 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436634 Predictor::LookupRequest::OnLookupFinished"));
-
predictor_->OnLookupFinished(this, url_, result == net::OK);
}
@@ -443,10 +438,6 @@ void Predictor::DiscardAllResults() {
// Overloaded Resolve() to take a vector of names.
void Predictor::ResolveList(const UrlList& urls,
UrlInfo::ResolutionMotivation motivation) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 Predictor::ResolveList"));
-
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
for (UrlList::const_iterator it = urls.begin(); it < urls.end(); ++it) {
@@ -689,33 +680,18 @@ void Predictor::FinalizeInitializationOnIOThread(
base::ListValue* referral_list,
IOThread* io_thread,
ProfileIOData* profile_io_data) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::FinalizeInitializationOnIOThread1"));
-
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
profile_io_data_ = profile_io_data;
initial_observer_.reset(new InitialObserver());
host_resolver_ = io_thread->globals()->host_resolver.get();
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::FinalizeInitializationOnIOThread2"));
-
net::URLRequestContext* context =
url_request_context_getter_->GetURLRequestContext();
transport_security_state_ = context->transport_security_state();
ssl_config_service_ = context->ssl_config_service();
proxy_service_ = context->proxy_service();
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::FinalizeInitializationOnIOThread3"));
-
// base::WeakPtrFactory instances need to be created and destroyed
// on the same thread. The predictor lives on the IO thread and will die
// from there so now that we're on the IO thread we need to properly
@@ -723,19 +699,9 @@ void Predictor::FinalizeInitializationOnIOThread(
// TODO(groby): Check if WeakPtrFactory has the same constraint.
weak_factory_.reset(new base::WeakPtrFactory<Predictor>(this));
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::FinalizeInitializationOnIOThread4"));
-
// Prefetch these hostnames on startup.
DnsPrefetchMotivatedList(startup_urls, UrlInfo::STARTUP_LIST_MOTIVATED);
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile5(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::FinalizeInitializationOnIOThread5"));
-
DeserializeReferrersThenDelete(referral_list);
}
@@ -776,11 +742,6 @@ void Predictor::DnsPrefetchList(const NameList& hostnames) {
void Predictor::DnsPrefetchMotivatedList(
const UrlList& urls,
UrlInfo::ResolutionMotivation motivation) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::DnsPrefetchMotivatedList"));
-
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI) ||
BrowserThread::CurrentlyOn(BrowserThread::IO));
if (!predictor_enabled_)
@@ -1059,11 +1020,6 @@ bool Predictor::WouldLikelyProxyURL(const GURL& url) {
UrlInfo* Predictor::AppendToResolutionQueue(
const GURL& url,
UrlInfo::ResolutionMotivation motivation) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::AppendToResolutionQueue1"));
-
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
DCHECK(url.has_host());
@@ -1082,29 +1038,22 @@ UrlInfo* Predictor::AppendToResolutionQueue(
return NULL;
}
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::AppendToResolutionQueue2"));
+ bool would_likely_proxy;
+ {
+ // TODO(ttuttle): Remove ScopedTracker below once crbug.com/436671 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 WouldLikelyProxyURL()"));
+ would_likely_proxy = WouldLikelyProxyURL(url);
+ }
- if (WouldLikelyProxyURL(url)) {
+ if (would_likely_proxy) {
info->DLogResultsStats("DNS PrefetchForProxiedRequest");
return NULL;
}
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::AppendToResolutionQueue3"));
-
info->SetQueuedState(motivation);
work_queue_.Push(url, motivation);
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::AppendToResolutionQueue4"));
-
StartSomeQueuedResolutions();
return info;
}
@@ -1132,11 +1081,6 @@ void Predictor::StartSomeQueuedResolutions() {
while (!work_queue_.IsEmpty() &&
pending_lookups_.size() < max_concurrent_dns_lookups_) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::StartSomeQueuedResolutions1"));
-
const GURL url(work_queue_.Pop());
UrlInfo* info = &results_[url];
DCHECK(info->HasUrl(url));
@@ -1149,17 +1093,14 @@ void Predictor::StartSomeQueuedResolutions() {
LookupRequest* request = new LookupRequest(this, host_resolver_, url);
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::StartSomeQueuedResolutions2"));
-
- int status = request->Start();
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 Predictor::StartSomeQueuedResolutions3"));
+ int status;
+ {
+ // TODO(ttuttle): Remove ScopedTracker below once crbug.com/436671 is
+ // fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 LookupRequest::Start()"));
+ status = request->Start();
+ }
if (status == net::ERR_IO_PENDING) {
// Will complete asynchronously.
diff --git a/chrome/browser/profiles/off_the_record_profile_io_data.cc b/chrome/browser/profiles/off_the_record_profile_io_data.cc
index 53cf0dd..bd815f8 100644
--- a/chrome/browser/profiles/off_the_record_profile_io_data.cc
+++ b/chrome/browser/profiles/off_the_record_profile_io_data.cc
@@ -8,7 +8,6 @@
#include "base/command_line.h"
#include "base/logging.h"
#include "base/prefs/pref_service.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/stl_util.h"
#include "base/threading/worker_pool.h"
#include "build/build_config.h"
@@ -201,11 +200,6 @@ void OffTheRecordProfileIOData::InitializeInternal(
ProfileParams* profile_params,
content::ProtocolHandlerMap* protocol_handlers,
content::URLRequestInterceptorScopedVector request_interceptors) const {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 OffTheRecordProfileIOData::InitializeInternal"));
-
net::URLRequestContext* main_context = main_request_context();
IOThread* const io_thread = profile_params->io_thread;
diff --git a/chrome/browser/profiles/profile_impl_io_data.cc b/chrome/browser/profiles/profile_impl_io_data.cc
index ae9af75..2d3c9cb 100644
--- a/chrome/browser/profiles/profile_impl_io_data.cc
+++ b/chrome/browser/profiles/profile_impl_io_data.cc
@@ -434,11 +434,6 @@ void ProfileImplIOData::InitializeInternal(
ProfileParams* profile_params,
content::ProtocolHandlerMap* protocol_handlers,
content::URLRequestInterceptorScopedVector request_interceptors) const {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ProfileImplIOData::InitializeInternal"));
-
// Set up a persistent store for use by the network stack on the IO thread.
base::FilePath network_json_store_filepath(
profile_path_.Append(chrome::kNetworkPersistentStateFilename));
@@ -457,11 +452,6 @@ void ProfileImplIOData::InitializeInternal(
chrome_network_delegate->set_predictor(predictor_.get());
if (domain_reliability_monitor_) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ProfileImplIOData::InitializeInternal1"));
-
domain_reliability::DomainReliabilityMonitor* monitor =
domain_reliability_monitor_.get();
monitor->InitURLRequestContext(main_context);
@@ -470,11 +460,6 @@ void ProfileImplIOData::InitializeInternal(
chrome_network_delegate->set_domain_reliability_monitor(monitor);
}
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ProfileImplIOData::InitializeInternal2"));
-
ApplyProfileParamsToContext(main_context);
if (http_server_properties_manager_)
@@ -509,12 +494,7 @@ void ProfileImplIOData::InitializeInternal(
scoped_refptr<net::CookieStore> cookie_store = NULL;
net::ChannelIDService* channel_id_service = NULL;
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile5(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ProfileImplIOData::InitializeInternal5"));
-
- // setup cookie store
+ // Set up cookie store.
if (!cookie_store.get()) {
DCHECK(!lazy_params_->cookie_path.empty());
@@ -530,12 +510,7 @@ void ProfileImplIOData::InitializeInternal(
main_context->set_cookie_store(cookie_store.get());
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile6(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ProfileImplIOData::InitializeInternal6"));
-
- // Setup server bound cert service.
+ // Set up server bound cert service.
if (!channel_id_service) {
DCHECK(!lazy_params_->channel_id_path.empty());
@@ -553,25 +528,20 @@ void ProfileImplIOData::InitializeInternal(
set_channel_id_service(channel_id_service);
main_context->set_channel_id_service(channel_id_service);
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile7(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ProfileImplIOData::InitializeInternal7"));
-
- net::HttpCache::DefaultBackend* main_backend =
- new net::HttpCache::DefaultBackend(
- net::DISK_CACHE,
- ChooseCacheBackendType(),
- lazy_params_->cache_path,
- lazy_params_->cache_max_size,
- BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE));
- scoped_ptr<net::HttpCache> main_cache = CreateMainHttpFactory(
- profile_params, main_backend);
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile71(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ProfileImplIOData::InitializeInternal71"));
+ scoped_ptr<net::HttpCache> main_cache;
+ {
+ // TODO(ttuttle): Remove ScopedTracker below once crbug.com/436671 is fixed.
+ tracked_objects::ScopedTracker tracking_profile(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 HttpCache construction"));
+ net::HttpCache::DefaultBackend* main_backend =
+ new net::HttpCache::DefaultBackend(
+ net::DISK_CACHE,
+ ChooseCacheBackendType(),
+ lazy_params_->cache_path,
+ lazy_params_->cache_max_size,
+ BrowserThread::GetMessageLoopProxyForThread(BrowserThread::CACHE));
+ main_cache = CreateMainHttpFactory(profile_params, main_backend);
+ }
main_http_factory_.reset(main_cache.release());
main_context->set_http_transaction_factory(main_http_factory_.get());
@@ -581,11 +551,6 @@ void ProfileImplIOData::InitializeInternal(
new net::FtpNetworkLayer(io_thread_globals->host_resolver.get()));
#endif // !defined(DISABLE_FTP_SUPPORT)
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile8(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ProfileImplIOData::InitializeInternal8"));
-
scoped_ptr<net::URLRequestJobFactoryImpl> main_job_factory(
new net::URLRequestJobFactoryImpl());
InstallProtocolHandlers(main_job_factory.get(), protocol_handlers);
@@ -603,11 +568,6 @@ void ProfileImplIOData::InitializeInternal(
ftp_factory_.get());
main_context->set_job_factory(main_job_factory_.get());
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile9(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "436671 ProfileImplIOData::InitializeInternal9"));
-
#if defined(ENABLE_EXTENSIONS)
InitializeExtensionsRequestContext(profile_params);
#endif
diff --git a/chrome/browser/profiles/profile_io_data.cc b/chrome/browser/profiles/profile_io_data.cc
index 8457344..88ea1699 100644
--- a/chrome/browser/profiles/profile_io_data.cc
+++ b/chrome/browser/profiles/profile_io_data.cc
@@ -16,7 +16,6 @@
#include "base/logging.h"
#include "base/path_service.h"
#include "base/prefs/pref_service.h"
-#include "base/profiler/scoped_tracker.h"
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
@@ -983,10 +982,6 @@ std::string ProfileIOData::GetSSLSessionCacheShard() {
void ProfileIOData::Init(
content::ProtocolHandlerMap* protocol_handlers,
content::URLRequestInterceptorScopedVector request_interceptors) const {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 ProfileIOData::Init"));
-
// The basic logic is implemented here. The specific initialization
// is done in InitializeInternal(), implemented by subtypes. Static helper
// functions have been provided to assist in common operations.
@@ -1007,18 +1002,10 @@ void ProfileIOData::Init(
const base::CommandLine& command_line =
*base::CommandLine::ForCurrentProcess();
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 ProfileIOData::Init1"));
-
// Create the common request contexts.
main_request_context_.reset(new net::URLRequestContext());
extensions_request_context_.reset(new net::URLRequestContext());
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 ProfileIOData::Init2"));
-
scoped_ptr<ChromeNetworkDelegate> network_delegate(
new ChromeNetworkDelegate(
#if defined(ENABLE_EXTENSIONS)
@@ -1045,10 +1032,6 @@ void ProfileIOData::Init(
new chrome_browser_net::ChromeFraudulentCertificateReporter(
main_request_context_.get()));
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 ProfileIOData::Init3"));
-
// NOTE: Proxy service uses the default io thread network delegate, not the
// delegate just created.
proxy_service_.reset(
@@ -1067,10 +1050,6 @@ void ProfileIOData::Init(
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE),
IsOffTheRecord()));
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 ProfileIOData::Init4"));
-
// Take ownership over these parameters.
cookie_settings_ = profile_params_->cookie_settings;
host_content_settings_map_ = profile_params_->host_content_settings_map;
@@ -1114,10 +1093,6 @@ void ProfileIOData::Init(
io_thread_globals->cert_verifier.get());
#endif
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/436671 is fixed.
- tracked_objects::ScopedTracker tracking_profile5(
- FROM_HERE_WITH_EXPLICIT_FUNCTION("436671 ProfileIOData::Init5"));
-
// Install the New Tab Page Interceptor.
if (profile_params_->new_tab_page_interceptor.get()) {
request_interceptors.push_back(
diff --git a/chrome/browser/task_manager/browser_process_resource_provider.cc b/chrome/browser/task_manager/browser_process_resource_provider.cc
index 72fcd1e9..319c817 100644
--- a/chrome/browser/task_manager/browser_process_resource_provider.cc
+++ b/chrome/browser/task_manager/browser_process_resource_provider.cc
@@ -33,25 +33,18 @@ gfx::ImageSkia* BrowserProcessResource::default_icon_ = NULL;
BrowserProcessResource::BrowserProcessResource()
: title_() {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 BrowserProcessResource::BrowserProcessResource1"));
-
#if defined(OS_WIN)
if (!default_icon_) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 BrowserProcessResource::BrowserProcessResource2"));
+ // TODO(afakhry): Remove ScopedTracker below once crbug.com/437890 is fixed.
+ tracked_objects::ScopedTracker tracking_profile1(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("437890 GetAppIcon()"));
HICON icon = GetAppIcon();
if (icon) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is
+ // TODO(afakhry): Remove ScopedTracker below once crbug.com/437890 is
// fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 BrowserProcessResource::BrowserProcessResource3"));
+ tracked_objects::ScopedTracker tracking_profile2(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("437890 CreateSkBitmapFromHICON()"));
scoped_ptr<SkBitmap> bitmap(IconUtil::CreateSkBitmapFromHICON(icon));
default_icon_ = new gfx::ImageSkia(gfx::ImageSkiaRep(*bitmap, 1.0f));
@@ -59,6 +52,10 @@ BrowserProcessResource::BrowserProcessResource()
}
#elif defined(OS_POSIX)
if (!default_icon_) {
+ // TODO(afakhry): Remove ScopedTracker below once crbug.com/437890 is fixed.
+ tracked_objects::ScopedTracker tracking_profile3(
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("437890 POSIX icon construction"));
+
ResourceBundle& rb = ResourceBundle::GetSharedInstance();
default_icon_ = rb.GetImageSkiaNamed(IDR_PRODUCT_LOGO_16);
}
@@ -67,12 +64,9 @@ BrowserProcessResource::BrowserProcessResource()
NOTIMPLEMENTED();
#endif // defined(OS_WIN)
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is
- // fixed.
+ // TODO(afakhry): Remove ScopedTracker below once crbug.com/437890 is fixed.
tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 BrowserProcessResource::BrowserProcessResource4"));
-
+ FROM_HERE_WITH_EXPLICIT_FUNCTION("437890 MakeThreadSafe()"));
default_icon_->MakeThreadSafe();
}
diff --git a/chrome/browser/task_manager/task_manager.cc b/chrome/browser/task_manager/task_manager.cc
index c9df8ec..9ca0de7 100644
--- a/chrome/browser/task_manager/task_manager.cc
+++ b/chrome/browser/task_manager/task_manager.cc
@@ -242,79 +242,32 @@ TaskManagerModel::TaskManagerModel(TaskManager* task_manager)
listen_requests_(0),
update_state_(IDLE),
is_updating_byte_count_(false) {
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile1(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 TaskManagerModel::TaskManagerModel1"));
-
AddResourceProvider(
new task_manager::BrowserProcessResourceProvider(task_manager));
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile2(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 TaskManagerModel::TaskManagerModel2"));
-
AddResourceProvider(new task_manager::WebContentsResourceProvider(
task_manager,
scoped_ptr<WebContentsInformation>(
new task_manager::BackgroundInformation())));
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile3(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 TaskManagerModel::TaskManagerModel3"));
-
AddResourceProvider(new task_manager::WebContentsResourceProvider(
task_manager,
scoped_ptr<WebContentsInformation>(
new task_manager::TabContentsInformation())));
#if defined(ENABLE_PRINT_PREVIEW)
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile4(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 TaskManagerModel::TaskManagerModel4"));
-
AddResourceProvider(new task_manager::WebContentsResourceProvider(
task_manager,
scoped_ptr<WebContentsInformation>(
new task_manager::PrintingInformation())));
#endif // ENABLE_PRINT_PREVIEW
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile5(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 TaskManagerModel::TaskManagerModel5"));
-
AddResourceProvider(new task_manager::WebContentsResourceProvider(
task_manager,
scoped_ptr<WebContentsInformation>(
new task_manager::PanelInformation())));
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile6(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 TaskManagerModel::TaskManagerModel6"));
-
AddResourceProvider(
new task_manager::ChildProcessResourceProvider(task_manager));
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile7(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 TaskManagerModel::TaskManagerModel7"));
-
AddResourceProvider(new task_manager::WebContentsResourceProvider(
task_manager,
scoped_ptr<WebContentsInformation>(
new task_manager::ExtensionInformation())));
-
- // TODO(vadimt): Remove ScopedTracker below once crbug.com/437890 is fixed.
- tracked_objects::ScopedTracker tracking_profile8(
- FROM_HERE_WITH_EXPLICIT_FUNCTION(
- "437890 TaskManagerModel::TaskManagerModel8"));
-
AddResourceProvider(new task_manager::WebContentsResourceProvider(
task_manager,
scoped_ptr<WebContentsInformation>(