Remove all FIXMEs in browser/

Changed them to TODO or NOTE or other as the situation called for it.

BUG=NONE
TEST=NONE (no code change)

Review URL: http://codereview.chromium.org/3599021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61861 0039d316-1c4b-4281-b951-d872f2087c98

9 files changed, 15 insertions, 14 deletions

diff --git a/chrome/browser/browser_init_browsertest.cc b/chrome/browser/browser_init_browsertest.cc
index ba86276f..bad04f1 100644
--- a/chrome/browser/browser_init_browsertest.cc
+++ b/chrome/browser/browser_init_browsertest.cc
@@ -78,7 +78,7 @@ IN_PROC_BROWSER_TEST_F(BrowserInitTest, FLAKY_BlockBadURLs) {
   BrowserInit::LaunchWithProfile launch(FilePath(), cmdline);
   launch.Launch(browser()->profile(), false);
 
-  // Give the browser a chance to start first. FIXME(jschuh)
+  // TODO(jschuh): Give the browser a chance to start first.
   PlatformThread::Sleep(50);
 
   // Skip about:blank in the first tab
diff --git a/chrome/browser/download/base_file.cc b/chrome/browser/download/base_file.cc
index 33b9372..f50c1f1 100644
--- a/chrome/browser/download/base_file.cc
+++ b/chrome/browser/download/base_file.cc
@@ -59,7 +59,7 @@ bool BaseFile::AppendDataToFile(const char* data, size_t data_len) {
 
   bytes_so_far_ += data_len;
 
-  // FIXME bug 595247: handle errors on file writes.
+  // TODO(phajdan.jr): handle errors on file writes. http://crbug.com/58355
   size_t written = file_stream_->Write(data, data_len, NULL);
   return (written == data_len);
 }
diff --git a/chrome/browser/download/download_history.cc b/chrome/browser/download/download_history.cc
index 9c86708..dd945c5 100644
--- a/chrome/browser/download/download_history.cc
+++ b/chrome/browser/download/download_history.cc
@@ -52,7 +52,7 @@ void DownloadHistory::AddEntry(
   // handles, so we use a negative value. Eventually, they could overlap, but
   // you'd have to do enough downloading that your ISP would likely stab you in
   // the neck first. YMMV.
-  // FIXME(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
+  // TODO(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
   HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
   if (download_item->is_otr() || download_item->is_extension_install() ||
       download_item->is_temporary() || !hs) {
@@ -71,7 +71,7 @@ void DownloadHistory::UpdateEntry(DownloadItem* download_item) {
   if (download_item->db_handle() <= kUninitializedHandle)
     return;
 
-  // FIXME(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
+  // TODO(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
   HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
   if (!hs)
     return;
@@ -87,7 +87,7 @@ void DownloadHistory::UpdateDownloadPath(DownloadItem* download_item,
   if (download_item->db_handle() <= kUninitializedHandle)
     return;
 
-  // FIXME(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
+  // TODO(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
   HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
   if (hs)
     hs->UpdateDownloadPath(new_path, download_item->db_handle());
@@ -98,7 +98,7 @@ void DownloadHistory::RemoveEntry(DownloadItem* download_item) {
   if (download_item->db_handle() <= kUninitializedHandle)
     return;
 
-  // FIXME(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
+  // TODO(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
   HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
   if (hs)
     hs->RemoveDownload(download_item->db_handle());
@@ -106,7 +106,7 @@ void DownloadHistory::RemoveEntry(DownloadItem* download_item) {
 
 void DownloadHistory::RemoveEntriesBetween(const base::Time remove_begin,
                                            const base::Time remove_end) {
-  // FIXME(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
+  // TODO(paulg) see bug 958058. EXPLICIT_ACCESS below is wrong.
   HistoryService* hs = profile_->GetHistoryService(Profile::EXPLICIT_ACCESS);
   if (hs)
     hs->RemoveDownloadsBetween(remove_begin, remove_end);
diff --git a/chrome/browser/gtk/gtk_theme_provider.h b/chrome/browser/gtk/gtk_theme_provider.h
index 2ecef7a..9a4d59c 100644
--- a/chrome/browser/gtk/gtk_theme_provider.h
+++ b/chrome/browser/gtk/gtk_theme_provider.h
@@ -66,7 +66,7 @@ class GtkThemeProvider : public BrowserThemeProvider,
   // away.
   GtkWidget* BuildChromeButton();
 
-  // FIXME
+  // Creates a theme-aware vertical separator widget.
   GtkWidget* CreateToolbarSeparator();
 
   // Whether we should use the GTK system theme.
diff --git a/chrome/browser/history/expire_history_backend.cc b/chrome/browser/history/expire_history_backend.cc
index 294c0e6..8cafc82 100644
--- a/chrome/browser/history/expire_history_backend.cc
+++ b/chrome/browser/history/expire_history_backend.cc
@@ -429,7 +429,7 @@ URLID ExpireHistoryBackend::ArchiveOneURL(const URLRow& url_row) {
   URLRow archived_row;
   if (archived_db_->GetRowForURL(url_row.url(), &archived_row)) {
     // TODO(sky): bug 1168470, need to archive past search terms.
-    // FIXME(brettw) should be copy the visit counts over? This will mean that
+    // TODO(brettw): should be copy the visit counts over? This will mean that
     // the main DB's visit counts are only for the last 3 months rather than
     // accumulative.
     archived_row.set_last_visit(url_row.last_visit());
@@ -655,7 +655,7 @@ bool ExpireHistoryBackend::ArchiveSomeOldHistory(
 }
 
 void ExpireHistoryBackend::ParanoidExpireHistory() {
-  // FIXME(brettw): Bug 1067331: write this to clean up any errors.
+  // TODO(brettw): Bug 1067331: write this to clean up any errors.
 }
 
 void ExpireHistoryBackend::ScheduleExpireHistoryIndexFiles() {
diff --git a/chrome/browser/history/history.cc b/chrome/browser/history/history.cc
index d70fd85..2b06a44 100644
--- a/chrome/browser/history/history.cc
+++ b/chrome/browser/history/history.cc
@@ -658,7 +658,7 @@ void HistoryService::ScheduleAutocomplete(HistoryURLProvider* provider,
 
 void HistoryService::ScheduleTask(SchedulePriority priority,
                                   Task* task) {
-  // FIXME(brettw) do prioritization.
+  // TODO(brettw): do prioritization.
   thread_->message_loop()->PostTask(FROM_HERE, task);
 }
 
diff --git a/chrome/browser/profile.cc b/chrome/browser/profile.cc
index eb7157d..b7f59fd 100644
--- a/chrome/browser/profile.cc
+++ b/chrome/browser/profile.cc
@@ -62,7 +62,7 @@ URLRequestContextGetter* Profile::default_request_context_;
 
 namespace {
 
-// FIXME: Duplicated in profile_impl.cc
+// TODO(pathorn): Duplicated in profile_impl.cc
 void CleanupRequestContext(ChromeURLRequestContextGetter* context) {
   if (context)
     context->CleanupOnUIThread();
diff --git a/chrome/browser/renderer_host/backing_store_proxy.cc b/chrome/browser/renderer_host/backing_store_proxy.cc
index ba3538b..3d2fd8e 100644
--- a/chrome/browser/renderer_host/backing_store_proxy.cc
+++ b/chrome/browser/renderer_host/backing_store_proxy.cc
@@ -90,7 +90,7 @@ void BackingStoreProxy::OnChannelError() {
     OnPaintToBackingStoreACK();
   }
 
-  // FIXME(brettw) does this mean we aren't getting any more messages and we
+  // TODO(brettw): does this mean we aren't getting any more messages and we
   // should delete outselves?
 }
 
diff --git a/chrome/browser/shell_integration.h b/chrome/browser/shell_integration.h
index 68a2812..33c82d8 100644
--- a/chrome/browser/shell_integration.h
+++ b/chrome/browser/shell_integration.h
@@ -72,8 +72,9 @@ class ShellIntegration {
   // which is deprecated. If |extension_app_id| is non-empty, an arguments
   // string is created using the kAppId=<id> flag. Otherwise, the kApp=<url> is
   // used.
-  // FIXME This function is dangerous, do not use!  You cannot treat
+  // NOTE: This function is dangerous, do not use!  You cannot treat
   // command lines as plain strings as there are metacharacters.
+  // TODO(evanm): remove it.
   static std::string GetCommandLineArgumentsCommon(const GURL& url,
       const string16& extension_app_id);