diff options
| author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-15 21:26:54 +0000 |
|---|---|---|
| committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-04-15 21:26:54 +0000 |
| commit | a1dadc4e183780c0b4cbcbab8d745ef22960ac27 (patch) | |
| tree | 983b8d512d1818d11c2fa63ea1a9f68308fd8ea3 /chrome/browser | |
| parent | 8750721039f3591412b0c9d80141b209b8ec549c (diff) | |
| download | chromium_src-a1dadc4e183780c0b4cbcbab8d745ef22960ac27.zip chromium_src-a1dadc4e183780c0b4cbcbab8d745ef22960ac27.tar.gz chromium_src-a1dadc4e183780c0b4cbcbab8d745ef22960ac27.tar.bz2 | |
Miscellaneous API sprucing.
- Camel-case event names.
- Rename chromium.self in content scripts to chromium.extension.
- Move onConnect in extension process to chromium.self.onConnect.
- Move definition of chromium.self to extension_process_bindings.js, so that it is near all the other extension process API.
- Make toolstrips not wrap by default
- Make toolstrips 21px high instead of 19, which was required to avoid an ugly white horizontal bar on my machine. This may be font dependent :(, which is another reason I need to finish making us paint the toolstrips background instead of using this CSS hack.
Review URL: http://codereview.chromium.org/67162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13792 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/extensions/extension_messages_unittest.cc | 6 | ||||
| -rwxr-xr-x | chrome/browser/resources/extensions_toolstrip.css | 5 |
2 files changed, 6 insertions, 5 deletions
diff --git a/chrome/browser/extensions/extension_messages_unittest.cc b/chrome/browser/extensions/extension_messages_unittest.cc index 565f664..009d574 100644 --- a/chrome/browser/extensions/extension_messages_unittest.cc +++ b/chrome/browser/extensions/extension_messages_unittest.cc @@ -15,7 +15,7 @@ TEST_F(RenderViewTest, ExtensionMessagesOpenChannel) { ExecuteJavaScript( "var e = new chromium.Extension('foobar');" "var port = e.connect();" - "port.onmessage.addListener(doOnMessage);" + "port.onMessage.addListener(doOnMessage);" "port.postMessage({message: 'content ready'});" "function doOnMessage(msg, port) {" " alert('content got: ' + msg.val);" @@ -56,8 +56,8 @@ TEST_F(RenderViewTest, ExtensionMessagesOpenChannel) { TEST_F(RenderViewTest, ExtensionMessagesOnConnect) { LoadHTML("<body></body>"); ExecuteJavaScript( - "chromium.onconnect.addListener(function (port) {" - " port.onmessage.addListener(doOnMessage);" + "chromium.self.onConnect.addListener(function (port) {" + " port.onMessage.addListener(doOnMessage);" " port.postMessage({message: 'onconnect'});" "});" "function doOnMessage(msg, port) {" diff --git a/chrome/browser/resources/extensions_toolstrip.css b/chrome/browser/resources/extensions_toolstrip.css index a8a332d..921f97f 100755 --- a/chrome/browser/resources/extensions_toolstrip.css +++ b/chrome/browser/resources/extensions_toolstrip.css @@ -10,6 +10,7 @@ body { #main { background: -webkit-gradient(linear, left top, left bottom, from(rgb(222, 234, 248)), to(rgb(237, 244, 252))); padding-top: 3px; - height:19px; - overflow:hidden; + height: 21px; + overflow: hidden; + white-space: nowrap; } |