diff options
| author | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-26 13:43:18 +0000 |
|---|---|---|
| committer | finnur@chromium.org <finnur@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-06-26 13:43:18 +0000 |
| commit | c5e5de90817010774159243e097620c25e7d1d5d (patch) | |
| tree | ec1ebae9797c70e9a27c82a9f47c3368bea20aed /chrome/browser | |
| parent | 6121c4837bac59131be7e4f17a3db42e4faef5c2 (diff) | |
| download | chromium_src-c5e5de90817010774159243e097620c25e7d1d5d.zip chromium_src-c5e5de90817010774159243e097620c25e7d1d5d.tar.gz chromium_src-c5e5de90817010774159243e097620c25e7d1d5d.tar.bz2 | |
Add a comment in the ImageLoadingTracker about the image decoding.
BUG=133471
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10658015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144168 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
| -rw-r--r-- | chrome/browser/extensions/image_loading_tracker.cc | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/browser/extensions/image_loading_tracker.cc b/chrome/browser/extensions/image_loading_tracker.cc index b8c30bb..ea84c34 100644 --- a/chrome/browser/extensions/image_loading_tracker.cc +++ b/chrome/browser/extensions/image_loading_tracker.cc @@ -104,6 +104,12 @@ class ImageLoadingTracker::ImageLoader reinterpret_cast<const unsigned char*>(file_contents.data()); webkit_glue::ImageDecoder decoder; scoped_ptr<SkBitmap> decoded(new SkBitmap()); + // Note: This class only decodes images from extension resources. Chrome + // doesn't (for security reasons) directly load extension resources provided + // by the extension author, but instead decodes them in a separate + // locked-down utility process. Only if the decoding succeeds is the image + // saved from memory to disk and subsequently used in the Chrome UI. + // Chrome is therefore decoding images here that were generated by Chrome. *decoded = decoder.Decode(data, file_contents.length()); if (decoded->empty()) { ReportBack(NULL, resource, gfx::Size(), id); |