diff options
author | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-29 23:47:05 +0000 |
---|---|---|
committer | avi@chromium.org <avi@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-01-29 23:47:05 +0000 |
commit | da2bfa49bd7721d552a8623fe826b438d2411ad8 (patch) | |
tree | 4daa7a9945d1a5561aaed61f5fce006884f6713c /chrome/browser | |
parent | 379d5814814273978ea4449b84e0828728f20acd (diff) | |
download | chromium_src-da2bfa49bd7721d552a8623fe826b438d2411ad8.zip chromium_src-da2bfa49bd7721d552a8623fe826b438d2411ad8.tar.gz chromium_src-da2bfa49bd7721d552a8623fe826b438d2411ad8.tar.bz2 |
Remove GetActiveWebContents from browser_tabstrip.
BUG=167548
TEST=no functional change
Review URL: https://chromiumcodereview.appspot.com/12038056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179466 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/browser')
19 files changed, 76 insertions, 64 deletions
diff --git a/chrome/browser/accessibility/accessibility_win_browsertest.cc b/chrome/browser/accessibility/accessibility_win_browsertest.cc index cb06199..5b980a1 100644 --- a/chrome/browser/accessibility/accessibility_win_browsertest.cc +++ b/chrome/browser/accessibility/accessibility_win_browsertest.cc @@ -10,8 +10,8 @@ #include "base/utf_string_conversions.h" #include "base/win/scoped_comptr.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/ui_controls.h" @@ -231,9 +231,8 @@ void AccessibilityWinBrowserTest::LoadInitialAccessibilityTreeFromHtml( // of the selected tab. IAccessible* AccessibilityWinBrowserTest::GetRendererAccessible() { - HWND hwnd_render_widget_host_view = - chrome::GetActiveWebContents(browser())->GetRenderWidgetHostView()-> - GetNativeView(); + HWND hwnd_render_widget_host_view = browser()->tab_strip_model()-> + GetActiveWebContents()->GetRenderWidgetHostView()->GetNativeView(); // Invoke windows screen reader detection by sending the WM_GETOBJECT message // with kIdCustom as the LPARAM. @@ -252,7 +251,7 @@ AccessibilityWinBrowserTest::GetRendererAccessible() { } void AccessibilityWinBrowserTest::ExecuteScript(wstring script) { - chrome::GetActiveWebContents(browser())->GetRenderViewHost()-> + browser()->tab_strip_model()->GetActiveWebContents()->GetRenderViewHost()-> ExecuteJavascriptInWebFrame(L"", script); } diff --git a/chrome/browser/chrome_plugin_browsertest.cc b/chrome/browser/chrome_plugin_browsertest.cc index fbcb053..6257b5e 100644 --- a/chrome/browser/chrome_plugin_browsertest.cc +++ b/chrome/browser/chrome_plugin_browsertest.cc @@ -14,7 +14,7 @@ #include "base/utf_string_conversions.h" #include "chrome/browser/plugins/plugin_prefs.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_tabstrip.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/ui_test_utils.h" #include "content/public/browser/browser_thread.h" @@ -82,7 +82,8 @@ class ChromePluginTest : public InProcessBrowserTest { } static void LoadAndWait(Browser* window, const GURL& url, bool pass) { - content::WebContents* web_contents = chrome::GetActiveWebContents(window); + content::WebContents* web_contents = + window->tab_strip_model()->GetActiveWebContents(); string16 expected_title(ASCIIToUTF16(pass ? "OK" : "plugin_not_found")); content::TitleWatcher title_watcher(web_contents, expected_title); title_watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL")); diff --git a/chrome/browser/download/chrome_download_manager_delegate.cc b/chrome/browser/download/chrome_download_manager_delegate.cc index 5d36135..e27136e 100644 --- a/chrome/browser/download/chrome_download_manager_delegate.cc +++ b/chrome/browser/download/chrome_download_manager_delegate.cc @@ -37,8 +37,9 @@ #include "chrome/browser/prefs/pref_service.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/safe_browsing/safe_browsing_service.h" -#include "chrome/browser/ui/browser_tabstrip.h" +#include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/host_desktop.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/extensions/feature_switch.h" #include "chrome/common/extensions/user_script.h" @@ -270,7 +271,8 @@ WebContents* ChromeDownloadManagerDelegate:: // than fully hiding the download from the user. Browser* last_active = chrome::FindLastActiveWithProfile(profile_, chrome::GetActiveDesktop()); - return last_active ? chrome::GetActiveWebContents(last_active) : NULL; + return last_active ? last_active->tab_strip_model()->GetActiveWebContents() + : NULL; #endif } diff --git a/chrome/browser/extensions/browser_action_apitest.cc b/chrome/browser/extensions/browser_action_apitest.cc index f0c7582..8c5cdf92e 100644 --- a/chrome/browser/extensions/browser_action_apitest.cc +++ b/chrome/browser/extensions/browser_action_apitest.cc @@ -3,7 +3,8 @@ // found in the LICENSE file. #include "chrome/browser/extensions/extension_system.h" -#include "chrome/browser/ui/browser_tabstrip.h" +#include "chrome/browser/ui/browser.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" // Tests that tooltips of a browser action icon can be specified using UTF8. // See http://crbug.com/25349. @@ -23,7 +24,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionBrowserTest, TitleLocalizationBrowserAction) { EXPECT_STREQ(WideToUTF8(L"Hreggvi\u00F0ur is my name").c_str(), extension->name().c_str()); int tab_id = ExtensionTabUtil::GetTabId( - chrome::GetActiveWebContents(browser())); + browser()->tab_strip_model()->GetActiveWebContents()); EXPECT_STREQ(WideToUTF8(L"Hreggvi\u00F0ur").c_str(), extension->browser_action()->GetTitle(tab_id).c_str()); } diff --git a/chrome/browser/extensions/extension_incognito_apitest.cc b/chrome/browser/extensions/extension_incognito_apitest.cc index 917dbb1c..c5b8a06 100644 --- a/chrome/browser/extensions/extension_incognito_apitest.cc +++ b/chrome/browser/extensions/extension_incognito_apitest.cc @@ -9,8 +9,8 @@ #include "chrome/browser/extensions/user_script_master.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/url_constants.h" #include "chrome/test/base/ui_test_utils.h" #include "content/public/browser/web_contents.h" @@ -32,7 +32,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoNoScript) { browser()->profile(), test_server()->GetURL("files/extensions/test_file.html")); - WebContents* tab = chrome::GetActiveWebContents(otr_browser); + WebContents* tab = otr_browser->tab_strip_model()->GetActiveWebContents(); // Verify the script didn't run. bool result = false; @@ -67,7 +67,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, IncognitoYesScript) { browser()->profile(), test_server()->GetURL("files/extensions/test_file.html")); - WebContents* tab = chrome::GetActiveWebContents(otr_browser); + WebContents* tab = otr_browser->tab_strip_model()->GetActiveWebContents(); // Verify the script ran. bool result = false; diff --git a/chrome/browser/intents/native_services_browsertest.cc b/chrome/browser/intents/native_services_browsertest.cc index bde8857..0daa02f 100644 --- a/chrome/browser/intents/native_services_browsertest.cc +++ b/chrome/browser/intents/native_services_browsertest.cc @@ -17,7 +17,7 @@ #include "chrome/browser/intents/native_services.h" #include "chrome/browser/intents/web_intents_util.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_tabstrip.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/chrome_switches.h" #include "chrome/test/base/in_process_browser_test.h" @@ -158,7 +158,8 @@ class NativeServicesBrowserTest : public InProcessBrowserTest { }; IN_PROC_BROWSER_TEST_F(NativeServicesBrowserTest, PickFileSelected) { - content::WebContents* tab = chrome::GetActiveWebContents(GetBrowser()); + content::WebContents* tab = + GetBrowser()->tab_strip_model()->GetActiveWebContents(); webkit_glue::WebIntentData intent; intent.action = ASCIIToUTF16(web_intents::kActionPick); @@ -187,7 +188,8 @@ IN_PROC_BROWSER_TEST_F(NativeServicesBrowserTest, PickFileSelected) { IN_PROC_BROWSER_TEST_F(NativeServicesBrowserTest, PickFileCancelled) { picker_success_mode = false; - content::WebContents* tab = chrome::GetActiveWebContents(GetBrowser()); + content::WebContents* tab = + GetBrowser()->tab_strip_model()->GetActiveWebContents(); webkit_glue::WebIntentData intent; intent.action = ASCIIToUTF16(web_intents::kActionPick); diff --git a/chrome/browser/net/websocket_browsertest.cc b/chrome/browser/net/websocket_browsertest.cc index 4537e4d..615bcc0 100644 --- a/chrome/browser/net/websocket_browsertest.cc +++ b/chrome/browser/net/websocket_browsertest.cc @@ -5,7 +5,7 @@ #include "base/string_util.h" #include "base/utf_string_conversions.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_tabstrip.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/test/base/in_process_browser_test.h" #include "chrome/test/base/ui_test_utils.h" #include "content/public/test/browser_test_utils.h" @@ -42,7 +42,8 @@ IN_PROC_BROWSER_TEST_F(WebSocketBrowserTest, WebSocketSplitSegments) { ASSERT_TRUE(ws_server_.Start()); // Setup page title observer. - content::WebContents* tab = chrome::GetActiveWebContents(browser()); + content::WebContents* tab = + browser()->tab_strip_model()->GetActiveWebContents(); content::TitleWatcher watcher(tab, ASCIIToUTF16("PASS")); watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL")); @@ -74,7 +75,8 @@ IN_PROC_BROWSER_TEST_F(WebSocketBrowserTest, ASSERT_TRUE(wss_server_.Start()); // Setup page title observer. - content::WebContents* tab = chrome::GetActiveWebContents(browser()); + content::WebContents* tab = + browser()->tab_strip_model()->GetActiveWebContents(); content::TitleWatcher watcher(tab, ASCIIToUTF16("PASS")); watcher.AlsoWaitForTitle(ASCIIToUTF16("FAIL")); diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc index 1cc1fb2..072ecab 100644 --- a/chrome/browser/policy/policy_browsertest.cc +++ b/chrome/browser/policy/policy_browsertest.cc @@ -1794,7 +1794,7 @@ class MediaStreamDevicesControllerBrowserTest content::MEDIA_NO_SERVICE); TabSpecificContentSettings* content_settings = TabSpecificContentSettings::FromWebContents( - chrome::GetActiveWebContents(browser())); + browser()->tab_strip_model()->GetActiveWebContents()); MediaStreamDevicesController controller( browser()->profile(), content_settings, @@ -1812,7 +1812,7 @@ class MediaStreamDevicesControllerBrowserTest content::MEDIA_DEVICE_VIDEO_CAPTURE); TabSpecificContentSettings* content_settings = TabSpecificContentSettings::FromWebContents( - chrome::GetActiveWebContents(browser())); + browser()->tab_strip_model()->GetActiveWebContents()); MediaStreamDevicesController controller( browser()->profile(), content_settings, request, base::Bind(&MediaStreamDevicesControllerBrowserTest::Accept, this)); diff --git a/chrome/browser/ui/browser_close_browsertest.cc b/chrome/browser/ui/browser_close_browsertest.cc index 94351a2..042fdf3 100644 --- a/chrome/browser/ui/browser_close_browsertest.cc +++ b/chrome/browser/ui/browser_close_browsertest.cc @@ -18,6 +18,7 @@ #include "chrome/browser/ui/browser_list.h" #include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_paths.h" #include "chrome/common/pref_names.h" #include "chrome/common/url_constants.h" @@ -176,7 +177,8 @@ class BrowserCloseTest : public InProcessBrowserTest { Browser* new_browser = new Browser(Browser::CreateParams(profile)); chrome::AddSelectedTabWithURL(new_browser, GURL(chrome::kAboutBlankURL), content::PAGE_TRANSITION_AUTO_TOPLEVEL); - content::WaitForLoadStop(chrome::GetActiveWebContents(new_browser)); + content::WaitForLoadStop( + new_browser->tab_strip_model()->GetActiveWebContents()); new_browser->window()->Show(); return new_browser; } diff --git a/chrome/browser/ui/browser_focus_uitest.cc b/chrome/browser/ui/browser_focus_uitest.cc index 939391d..11dc8ef 100644 --- a/chrome/browser/ui/browser_focus_uitest.cc +++ b/chrome/browser/ui/browser_focus_uitest.cc @@ -466,7 +466,7 @@ IN_PROC_BROWSER_TEST_F(BrowserFocusTest, focused_browser->window()->Activate(); ASSERT_TRUE(content::ExecuteScript( - chrome::GetActiveWebContents(unfocused_browser), + unfocused_browser->tab_strip_model()->GetActiveWebContents(), "stealFocus();")); // Make sure the first browser is still active. diff --git a/chrome/browser/ui/browser_tabstrip.cc b/chrome/browser/ui/browser_tabstrip.cc index 708a746..8222e62 100644 --- a/chrome/browser/ui/browser_tabstrip.cc +++ b/chrome/browser/ui/browser_tabstrip.cc @@ -18,10 +18,6 @@ namespace chrome { -content::WebContents* GetActiveWebContents(const Browser* browser) { - return browser->tab_strip_model()->GetActiveWebContents(); -} - void AddBlankTabAt(Browser* browser, int index, bool foreground) { // TODO(scottmg): http://crbug.com/128578 // This is necessary because WebContentsViewAura doesn't have enough context diff --git a/chrome/browser/ui/browser_tabstrip.h b/chrome/browser/ui/browser_tabstrip.h index c6ec1b9..29612e9 100644 --- a/chrome/browser/ui/browser_tabstrip.h +++ b/chrome/browser/ui/browser_tabstrip.h @@ -24,8 +24,6 @@ class Rect; namespace chrome { -content::WebContents* GetActiveWebContents(const Browser* browser); - // Adds a blank tab to the tab strip of the specified browser; an |index| of -1 // means to append it to the end of the tab strip. void AddBlankTabAt(Browser* browser, int index, bool foreground); diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm index 2fcbb7c..36f0b14 100644 --- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm +++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm @@ -14,7 +14,7 @@ #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_info_util.h" #include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h" -#include "chrome/browser/ui/browser_tabstrip.h" +#include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_window_state.h" #include "chrome/browser/ui/cocoa/last_active_browser_cocoa.h" #import "chrome/browser/ui/cocoa/browser/avatar_button_controller.h" @@ -34,6 +34,7 @@ #include "chrome/browser/ui/fullscreen/fullscreen_controller.h" #include "chrome/browser/ui/search/search_model.h" #include "chrome/browser/ui/search/search_ui.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_switches.h" #include "chrome/common/pref_names.h" #include "content/public/browser/render_widget_host_view.h" @@ -496,7 +497,8 @@ willPositionSheet:(NSWindow*)sheet // If the relayout shifts the content area up or down, let the renderer know. if (contentShifted) { - if (WebContents* contents = chrome::GetActiveWebContents(browser_.get())) { + if (WebContents* contents = + browser_->tab_strip_model()->GetActiveWebContents()) { if (RenderWidgetHostView* rwhv = contents->GetRenderWidgetHostView()) rwhv->WindowFrameChanged(); } diff --git a/chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc b/chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc index 1696e20..0a3688c 100644 --- a/chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc +++ b/chrome/browser/ui/fullscreen/fullscreen_controller_state_test.cc @@ -10,9 +10,9 @@ #include <iostream> #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/fullscreen/fullscreen_controller.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "content/public/common/url_constants.h" #include "testing/gtest/include/gtest/gtest.h" @@ -305,11 +305,11 @@ bool FullscreenControllerStateTest::InvokeEvent(Event event) { break; case TAB_FULLSCREEN_TRUE: GetFullscreenController()->ToggleFullscreenModeForTab( - chrome::GetActiveWebContents(GetBrowser()), true); + GetBrowser()->tab_strip_model()->GetActiveWebContents(), true); break; case TAB_FULLSCREEN_FALSE: GetFullscreenController()->ToggleFullscreenModeForTab( - chrome::GetActiveWebContents(GetBrowser()), false); + GetBrowser()->tab_strip_model()->GetActiveWebContents(), false); break; #if defined(OS_WIN) case METRO_SNAP_TRUE: diff --git a/chrome/browser/ui/gtk/browser_titlebar.cc b/chrome/browser/ui/gtk/browser_titlebar.cc index 618b7a5..167664d 100644 --- a/chrome/browser/ui/gtk/browser_titlebar.cc +++ b/chrome/browser/ui/gtk/browser_titlebar.cc @@ -26,7 +26,6 @@ #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_commands.h" -#include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/gtk/accelerators_gtk.h" #include "chrome/browser/ui/gtk/avatar_menu_button_gtk.h" #include "chrome/browser/ui/gtk/browser_window_gtk.h" @@ -40,6 +39,7 @@ #include "chrome/browser/ui/gtk/nine_box.h" #include "chrome/browser/ui/gtk/tabs/tab_strip_gtk.h" #include "chrome/browser/ui/gtk/unity_service.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/ui/toolbar/encoding_menu_controller.h" #include "chrome/browser/ui/toolbar/wrench_menu_model.h" #include "chrome/common/chrome_notification_types.h" @@ -940,7 +940,7 @@ bool BrowserTitlebar::IsCommandIdChecked(int command_id) const { EncodingMenuController controller; if (controller.DoesCommandBelongToEncodingMenu(command_id)) { WebContents* web_contents = - chrome::GetActiveWebContents(browser_window_->browser()); + browser_window_->browser()->tab_strip_model()->GetActiveWebContents(); if (web_contents) { return controller.IsItemChecked(browser_window_->browser()->profile(), web_contents->GetEncoding(), diff --git a/chrome/browser/ui/pdf/pdf_browsertest.cc b/chrome/browser/ui/pdf/pdf_browsertest.cc index 480d015..d42c169 100644 --- a/chrome/browser/ui/pdf/pdf_browsertest.cc +++ b/chrome/browser/ui/pdf/pdf_browsertest.cc @@ -9,9 +9,9 @@ #include "base/string_util.h" #include "base/utf_string_conversions.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/snapshot_tab_helper.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/common/chrome_notification_types.h" #include "chrome/common/chrome_paths.h" #include "chrome/test/base/in_process_browser_test.h" @@ -85,7 +85,8 @@ class PDFBrowserTest : public InProcessBrowserTest, bool VerifySnapshot(const std::string& expected_filename) { snapshot_different_ = true; expected_filename_ = expected_filename; - WebContents* web_contents = chrome::GetActiveWebContents(browser()); + WebContents* web_contents = + browser()->tab_strip_model()->GetActiveWebContents(); SnapshotTabHelper::FromWebContents(web_contents)->CaptureSnapshot(); ui_test_utils::RegisterAndWait( this, @@ -112,8 +113,8 @@ class PDFBrowserTest : public InProcessBrowserTest, string16 query = UTF8ToUTF16( std::string("xyzxyz" + base::IntToString(next_dummy_search_value_++))); ASSERT_EQ(0, ui_test_utils::FindInPage( - chrome::GetActiveWebContents(browser()), query, true, false, NULL, - NULL)); + browser()->tab_strip_model()->GetActiveWebContents(), + query, true, false, NULL, NULL)); } private: @@ -244,13 +245,14 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_Scroll) { wheel_event.type = WebKit::WebInputEvent::MouseWheel; wheel_event.deltaY = -200; wheel_event.wheelTicksY = -2; - WebContents* web_contents = chrome::GetActiveWebContents(browser()); + WebContents* web_contents = + browser()->tab_strip_model()->GetActiveWebContents(); web_contents->GetRenderViewHost()->ForwardWheelEvent(wheel_event); ASSERT_NO_FATAL_FAILURE(WaitForResponse()); int y_offset = 0; ASSERT_TRUE(content::ExecuteScriptAndExtractInt( - chrome::GetActiveWebContents(browser()), + browser()->tab_strip_model()->GetActiveWebContents(), "window.domAutomationController.send(plugin.pageYOffset())", &y_offset)); ASSERT_GT(y_offset, 0); @@ -266,7 +268,8 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_FindAndCopy) { ASSERT_NO_FATAL_FAILURE(Load()); // Verifies that find in page works. ASSERT_EQ(3, ui_test_utils::FindInPage( - chrome::GetActiveWebContents(browser()), UTF8ToUTF16("adipiscing"), + browser()->tab_strip_model()->GetActiveWebContents(), + UTF8ToUTF16("adipiscing"), true, false, NULL, NULL)); // Verify that copying selected text works. @@ -278,7 +281,8 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, MAYBE_FindAndCopy) { objects[ui::Clipboard::CBF_TEXT] = params; clipboard->WriteObjects(ui::Clipboard::BUFFER_STANDARD, objects); - chrome::GetActiveWebContents(browser())->GetRenderViewHost()->Copy(); + browser()->tab_strip_model()->GetActiveWebContents()-> + GetRenderViewHost()->Copy(); ASSERT_NO_FATAL_FAILURE(WaitForResponse()); std::string text; @@ -296,7 +300,7 @@ IN_PROC_BROWSER_TEST_P(PDFBrowserTest, Loading) { ASSERT_TRUE(pdf_test_server()->Start()); NavigationController* controller = - &(chrome::GetActiveWebContents(browser())->GetController()); + &(browser()->tab_strip_model()->GetActiveWebContents()->GetController()); content::NotificationRegistrar registrar; registrar.Add(this, content::NOTIFICATION_LOAD_STOP, @@ -338,7 +342,7 @@ IN_PROC_BROWSER_TEST_P(PDFBrowserTest, Loading) { // and before creating a byte-range request loader. bool complete = false; ASSERT_TRUE(content::ExecuteScriptAndExtractBool( - chrome::GetActiveWebContents(browser()), + browser()->tab_strip_model()->GetActiveWebContents(), "window.domAutomationController.send(plugin.documentLoadComplete())", &complete)); if (complete) @@ -348,7 +352,8 @@ IN_PROC_BROWSER_TEST_P(PDFBrowserTest, Loading) { // nested message loop for the JS call. if (last_count != load_stop_notification_count()) continue; - content::WaitForLoadStop(chrome::GetActiveWebContents(browser())); + content::WaitForLoadStop( + browser()->tab_strip_model()->GetActiveWebContents()); } } } @@ -361,22 +366,22 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, Action) { ASSERT_NO_FATAL_FAILURE(Load()); ASSERT_TRUE(content::ExecuteScript( - chrome::GetActiveWebContents(browser()), + browser()->tab_strip_model()->GetActiveWebContents(), "document.getElementsByName('plugin')[0].fitToHeight();")); std::string zoom1, zoom2; ASSERT_TRUE(content::ExecuteScriptAndExtractString( - chrome::GetActiveWebContents(browser()), + browser()->tab_strip_model()->GetActiveWebContents(), "window.domAutomationController.send(" " document.getElementsByName('plugin')[0].getZoomLevel().toString())", &zoom1)); ASSERT_TRUE(content::ExecuteScript( - chrome::GetActiveWebContents(browser()), + browser()->tab_strip_model()->GetActiveWebContents(), "document.getElementsByName('plugin')[0].fitToWidth();")); ASSERT_TRUE(content::ExecuteScriptAndExtractString( - chrome::GetActiveWebContents(browser()), + browser()->tab_strip_model()->GetActiveWebContents(), "window.domAutomationController.send(" " document.getElementsByName('plugin')[0].getZoomLevel().toString())", &zoom2)); @@ -393,14 +398,16 @@ IN_PROC_BROWSER_TEST_F(PDFBrowserTest, DISABLED_OnLoadAndReload) { content::WindowedNotificationObserver observer( content::NOTIFICATION_LOAD_STOP, content::Source<NavigationController>( - &chrome::GetActiveWebContents(browser())->GetController())); + &browser()->tab_strip_model()->GetActiveWebContents()-> + GetController())); ASSERT_TRUE(content::ExecuteScript( - chrome::GetActiveWebContents(browser()), + browser()->tab_strip_model()->GetActiveWebContents(), "reloadPDF();")); observer.Wait(); ASSERT_EQ("success", - chrome::GetActiveWebContents(browser())->GetURL().query()); + browser()->tab_strip_model()->GetActiveWebContents()-> + GetURL().query()); } } // namespace diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc index f910da3..46cc290 100644 --- a/chrome/browser/ui/views/frame/browser_view.cc +++ b/chrome/browser/ui/views/frame/browser_view.cc @@ -1532,8 +1532,7 @@ bool BrowserView::ShouldShowWindowTitle() const { gfx::ImageSkia BrowserView::GetWindowAppIcon() { if (browser_->is_app()) { - WebContents* contents = - browser_->tab_strip_model()->GetActiveWebContents(); + WebContents* contents = browser_->tab_strip_model()->GetActiveWebContents(); extensions::TabHelper* extensions_tab_helper = contents ? extensions::TabHelper::FromWebContents(contents) : NULL; if (extensions_tab_helper && extensions_tab_helper->GetExtensionAppIcon()) @@ -2545,8 +2544,7 @@ void BrowserView::DoCutCopyPaste(void (content::RenderWidgetHost::*method)(), int windows_msg_id, #endif int command_id) { - WebContents* contents = - browser_->tab_strip_model()->GetActiveWebContents(); + WebContents* contents = browser_->tab_strip_model()->GetActiveWebContents(); if (!contents) return; if (DoCutCopyPasteForWebContents(contents, method)) diff --git a/chrome/browser/ui/views/select_file_dialog_extension.cc b/chrome/browser/ui/views/select_file_dialog_extension.cc index 7c21687..630e7de 100644 --- a/chrome/browser/ui/views/select_file_dialog_extension.cc +++ b/chrome/browser/ui/views/select_file_dialog_extension.cc @@ -24,12 +24,12 @@ #include "chrome/browser/ui/browser.h" #include "chrome/browser/ui/browser_finder.h" #include "chrome/browser/ui/browser_list.h" -#include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/chrome_select_file_policy.h" #include "chrome/browser/ui/extensions/native_app_window.h" #include "chrome/browser/ui/extensions/shell_window.h" #include "chrome/browser/ui/host_desktop.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/ui/views/extensions/extension_dialog.h" #include "content/public/browser/browser_thread.h" #include "ui/shell_dialogs/selected_file_info.h" @@ -270,7 +270,7 @@ void SelectFileDialogExtension::SelectFileImpl( chrome::FindLastActiveWithHostDesktopType(chrome::GetActiveDesktop()); if (owner_browser) { base_window = owner_browser->window(); - web_contents = chrome::GetActiveWebContents(owner_browser); + web_contents = owner_browser->tab_strip_model()->GetActiveWebContents(); profile_ = Profile::FromBrowserContext(web_contents->GetBrowserContext()); } else if (owner_window) { // If an owner_window was supplied but we couldn't find a browser, this diff --git a/chrome/browser/ui/views/wrench_menu.cc b/chrome/browser/ui/views/wrench_menu.cc index b64513c..c7b65df 100644 --- a/chrome/browser/ui/views/wrench_menu.cc +++ b/chrome/browser/ui/views/wrench_menu.cc @@ -15,10 +15,10 @@ #include "chrome/browser/bookmarks/bookmark_model_factory.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/ui/browser.h" -#include "chrome/browser/ui/browser_tabstrip.h" #include "chrome/browser/ui/browser_window.h" #include "chrome/browser/ui/search/search.h" #include "chrome/browser/ui/search/search_model.h" +#include "chrome/browser/ui/tabs/tab_strip_model.h" #include "chrome/browser/ui/views/bookmarks/bookmark_menu_delegate.h" #include "chrome/common/chrome_notification_types.h" #include "content/public/browser/host_zoom_map.h" @@ -625,7 +625,8 @@ class WrenchMenu::ZoomView : public WrenchMenuView, void UpdateZoomControls() { bool enable_increment = false; bool enable_decrement = false; - WebContents* selected_tab = chrome::GetActiveWebContents(menu_->browser_); + WebContents* selected_tab = + menu_->browser_->tab_strip_model()->GetActiveWebContents(); int zoom = 100; if (selected_tab) zoom = selected_tab->GetZoomPercent(&enable_increment, &enable_decrement); @@ -645,7 +646,8 @@ class WrenchMenu::ZoomView : public WrenchMenuView, int max_w = 0; - WebContents* selected_tab = chrome::GetActiveWebContents(menu_->browser_); + WebContents* selected_tab = + menu_->browser_->tab_strip_model()->GetActiveWebContents(); if (selected_tab) { int min_percent = selected_tab->GetMinimumZoomPercent(); int max_percent = selected_tab->GetMaximumZoomPercent(); |