diff options
| author | haven@chromium.org <haven@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-27 13:19:30 +0000 |
|---|---|---|
| committer | haven@chromium.org <haven@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-02-27 13:19:30 +0000 |
| commit | 3d78cbe8a605ce45747c65c1d85b8e27973aa113 (patch) | |
| tree | fd1dd2732f807ff7715fe185277f5280e76dcc74 /chrome/chrome.gyp | |
| parent | d97209dbb82e5a65fca0af6a10264054598ccefe (diff) | |
| download | chromium_src-3d78cbe8a605ce45747c65c1d85b8e27973aa113.zip chromium_src-3d78cbe8a605ce45747c65c1d85b8e27973aa113.tar.gz chromium_src-3d78cbe8a605ce45747c65c1d85b8e27973aa113.tar.bz2 | |
Resubmit of refactoring ImageWriterPrivate into the utility process.
I had a few errors in the CL I submitted last week. I need to resubmit, but to
do that in a new CL I need new approvals (I'm not a committer). The changes
should be minor. The first PS is the original CL, the second PS is the changes.
Summary of changes:
* Didn't properly clean up some objects when testing. In the long run I'd like
to see if I could limit the refcounting some more, but in the mean time I have
to be diligent about cleanup. Cleanup functions are now automatically added
when the operation is set up for testing.
* When writing we write the whole buffer and not just the part read (due to
Windows alignment requirements). This extra was uninitialized but is now zeroed.
* When validating, if less data was read from the disk than was in the image,
then the image was compared against uninitialized memory. This was fixed by
failing immediately if fewer bytes are read.
See original CL: https://codereview.chromium.org/61643015/
BUG=345659
TBR=jorgelo@chromium.org
TBR=mpcomplete@chromium.org
TBR=thestig@chromium.org
TBR=jln@chromium.org
Review URL: https://codereview.chromium.org/176103002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253773 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome.gyp')
| -rw-r--r-- | chrome/chrome.gyp | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/chrome/chrome.gyp b/chrome/chrome.gyp index f4c3199..6b33f6a 100644 --- a/chrome/chrome.gyp +++ b/chrome/chrome.gyp @@ -265,6 +265,12 @@ 'utility/cloud_print/pwg_encoder.h', 'utility/extensions/unpacker.cc', 'utility/extensions/unpacker.h', + 'utility/image_writer/error_messages.cc', + 'utility/image_writer/error_messages.h', + 'utility/image_writer/image_writer.cc', + 'utility/image_writer/image_writer.h', + 'utility/image_writer/image_writer_handler.cc', + 'utility/image_writer/image_writer_handler.h', 'utility/importer/bookmark_html_reader.cc', 'utility/importer/bookmark_html_reader.h', 'utility/importer/bookmarks_file_importer.cc', |