diff options
author | oshima <oshima@chromium.org> | 2015-10-27 12:06:52 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-10-27 19:07:47 +0000 |
commit | f38efa9db8bf4698cf4e0e68c2c4225efcb3081e (patch) | |
tree | 6e15d9a97d208ba225332850a8367ff832d9a6cb /chrome/chrome.user32.delay.imports | |
parent | 541a10c2c111cce8ebfb71e81324a59f94a4810a (diff) | |
download | chromium_src-f38efa9db8bf4698cf4e0e68c2c4225efcb3081e.zip chromium_src-f38efa9db8bf4698cf4e0e68c2c4225efcb3081e.tar.gz chromium_src-f38efa9db8bf4698cf4e0e68c2c4225efcb3081e.tar.bz2 |
Refactor screen_dimmer to share code and shrink Shell interface. DimWindow : a window that implement dimming. You can just add it to container and let it handle its state. ScreenDimmer : an object that keeps the state consistent across multiple root windows. It's owned by the primary container and gets destroyed when the container is destroyed.
* Added wm::SetWindowVisiblityChangesAnimated to ui/wm/core/visibility_controller.h, to animate individual window's visibility change. The dim layer can be added to root (or any other container), and we probably don't want to enable animation for all children in such case.
* Use solid color layer for modal background. it's more efficient.
* Use WindowTracker to keep track of the non toplevel windows in RootWindowController::CloseChildWindows(). This was causing asan failure reported in crbug.com/547178
BUG=478438,547178
TBR=sky@chromium.org
TEST=updated existing screen_dimmer_unittest, VisibilityControllerTest.SetWindowVisibilityChangesAnimated, asan bot fails without change in RootWindowController::CloseChildWindows
Review URL: https://codereview.chromium.org/1426573004
Cr-Commit-Position: refs/heads/master@{#356359}
Diffstat (limited to 'chrome/chrome.user32.delay.imports')
0 files changed, 0 insertions, 0 deletions