diff options
| author | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-21 16:04:10 +0000 |
|---|---|---|
| committer | asvitkine@chromium.org <asvitkine@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-04-21 16:04:10 +0000 |
| commit | 4fc87c0f5d78dbcba2e12ce20636229a23b470b1 (patch) | |
| tree | a5bbac257988c22a3a73b0a2d002f94f1856aa27 /chrome/chrome_browser.gypi | |
| parent | c4de5dfacd5f7fa135ee7069c9bfe7292c7d4c99 (diff) | |
| download | chromium_src-4fc87c0f5d78dbcba2e12ce20636229a23b470b1.zip chromium_src-4fc87c0f5d78dbcba2e12ce20636229a23b470b1.tar.gz chromium_src-4fc87c0f5d78dbcba2e12ce20636229a23b470b1.tar.bz2 | |
Implementation of "Select tabs when dragging onto them".
Mac and Windows implementation.
Also known as "spring loaded tabs" - which comes from the term
Apple coined for similar functionality in the Finder with folders
(spring loaded folders).
This CL adds the helper class SpringLoadedTabStripHelper which contains
the cross-platform logic for transitioning to the tab with a delay.
The class is then used from platform-specific tab strip code in response
to drag events.
The delay between when you hover over a tab and the tab selection
taking place is currently 0.5 seconds.
Also, the CL changes the "drop indicator over tab" area to be the middle
1/2 of the tab, instead of 1/3 to make it easier to hover of a tab on
Windows. (On the Mac, it was already at 1/2.)
BUG=19071
TEST=1. Select some text and drag it over an inactive tab. In 0.5 seconds,
the tab selection should switch to that tab. You should now be able to
drag the text into the content area of that tab (e.g. into a text box).
2. Select some text and drag it over an inactive tab. Without waiting
over 0.5 seconds, move the mouse away from that tab. No tab switch
should take place.
Review URL: http://codereview.chromium.org/6806013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82492 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser.gypi')
| -rw-r--r-- | chrome/chrome_browser.gypi | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index 19a923d..afdce7c 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -2807,6 +2807,8 @@ 'browser/ui/tabs/dock_info_gtk.cc', 'browser/ui/tabs/dock_info_mac.cc', 'browser/ui/tabs/dock_info_win.cc', + 'browser/ui/tabs/hover_tab_selector.cc', + 'browser/ui/tabs/hover_tab_selector.h', 'browser/ui/tabs/tab_menu_model.cc', 'browser/ui/tabs/tab_menu_model.h', 'browser/ui/title_prefix_matcher.cc', |