diff options
| author | nhiroki <nhiroki@chromium.org> | 2014-09-15 21:57:07 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-16 04:58:17 +0000 |
| commit | f03864238c8a90971f6b0c4d0f5acb894c0dfcd2 (patch) | |
| tree | 3faee5dfbefb01378013b219305c3226daee261e /chrome/chrome_browser.gypi | |
| parent | d56989c2dd99ba9dd241952df0632397c58bfdfa (diff) | |
| download | chromium_src-f03864238c8a90971f6b0c4d0f5acb894c0dfcd2.zip chromium_src-f03864238c8a90971f6b0c4d0f5acb894c0dfcd2.tar.gz chromium_src-f03864238c8a90971f6b0c4d0f5acb894c0dfcd2.tar.bz2 | |
Revert of Revert CL 117933003. Re-add resource speculative prefetching code. (patchset #10 id:180001 of https://codereview.chromium.org/462423004/)
Reason for revert:
This caused a bunch of memory leaks in following tests:
- ResourcePrefetcherTest.TestPrefetcherFinishes
- ResourcePrefetcherTest.TestPrefetcherStopped
Linux Chromium OS ASan LSan Tests (3)
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%283%29/builds/3216
Linux ASan LSan Tests (2)
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7460
Original issue's description:
> Revert CL 117933003. Re-add speculative resource prefetching code.
> https://codereview.chromium.org/117933003/
>
> The speculative resource prefetching code was experimental code developed by
> shishir@. He found that it has little improvement on desktop Chrome (win). We
> though this should be beneficial to mobile browsers. After discussing with
> tburkard@ and kenjibaheux@, we decided to bring the code back and do more
> analysis on mobile devices. Reverting the patchset to re-add the code is the
> first step.
>
> The following design doc has discussed all related approaches and action items.
> https://docs.google.com/a/google.com/document/d/1ie3hu-zNNXvmTXm3aJAtKUGOh6nZfbNjA0aZE1bzzIg/edit?usp=sharing
>
> BUG=408399, 405690
>
> Committed: https://crrev.com/825722d5939dc0832d124b70958501611e6a4628
> Cr-Commit-Position: refs/heads/master@{#294899}
TBR=shishir@chromium.org,tburkard@chromium.org,kenjibaheux@chromium.org,jam@chromium.org,thestig@chromium.org,zhenw@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408399, 405690
Review URL: https://codereview.chromium.org/577543002
Cr-Commit-Position: refs/heads/master@{#295011}
Diffstat (limited to 'chrome/chrome_browser.gypi')
| -rw-r--r-- | chrome/chrome_browser.gypi | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi index 47364be..3b5527a 100644 --- a/chrome/chrome_browser.gypi +++ b/chrome/chrome_browser.gypi @@ -778,8 +778,6 @@ 'browser/net/quota_policy_channel_id_store.h', 'browser/net/referrer.cc', 'browser/net/referrer.h', - 'browser/net/resource_prefetch_predictor_observer.cc', - 'browser/net/resource_prefetch_predictor_observer.h', 'browser/net/safe_search_util.cc', 'browser/net/safe_search_util.h', 'browser/net/service_providers_win.cc', @@ -851,20 +849,6 @@ 'browser/predictors/predictor_database_factory.h', 'browser/predictors/predictor_table_base.cc', 'browser/predictors/predictor_table_base.h', - 'browser/predictors/resource_prefetch_common.cc', - 'browser/predictors/resource_prefetch_common.h', - 'browser/predictors/resource_prefetch_predictor.cc', - 'browser/predictors/resource_prefetch_predictor.h', - 'browser/predictors/resource_prefetch_predictor_factory.cc', - 'browser/predictors/resource_prefetch_predictor_factory.h', - 'browser/predictors/resource_prefetch_predictor_tab_helper.cc', - 'browser/predictors/resource_prefetch_predictor_tab_helper.h', - 'browser/predictors/resource_prefetch_predictor_tables.cc', - 'browser/predictors/resource_prefetch_predictor_tables.h', - 'browser/predictors/resource_prefetcher.cc', - 'browser/predictors/resource_prefetcher.h', - 'browser/predictors/resource_prefetcher_manager.cc', - 'browser/predictors/resource_prefetcher_manager.h', 'browser/pref_service_flags_storage.cc', 'browser/pref_service_flags_storage.h', 'browser/prefetch/prefetch.cc', |