diff options
| author | stevenjb <stevenjb@chromium.org> | 2015-06-25 09:36:08 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-06-25 16:36:55 +0000 |
| commit | 76d83e95044a4361521fa610c60b8465016e6c8f (patch) | |
| tree | 85577e648f3ad4697d8af7c24528cd9488922149 /chrome/chrome_browser_chromeos.gypi | |
| parent | a5db6be95574d5d903461b5a0c22bf883c6026ba (diff) | |
| download | chromium_src-76d83e95044a4361521fa610c60b8465016e6c8f.zip chromium_src-76d83e95044a4361521fa610c60b8465016e6c8f.tar.gz chromium_src-76d83e95044a4361521fa610c60b8465016e6c8f.tar.bz2 | |
Revert of Proposed alternative for supporting ChromeVox keyboard commands. (patchset #8 id:200001 of https://codereview.chromium.org/1185753008/)
Reason for revert:
Appears to be causing crashes. See https://crbug.com/504400.
Original issue's description:
> Proposed alternative for supporting ChromeVox keyboard commands.
>
> ChromeVox, a component extension, has some special use cases not currently supported by the chrome.commands API. Over the past year or so, it has become more clear that these special use cases mean non-trivial changes to the commands API. These changes have also uncovered some bugs due to (a) component extension events and (b) prefs.
>
> This is a proposed simple alternative which still utilizes the same manifest format as the commands API and the same extension listener, but performs its own dispatch. It also need not register accelerators in advance as it hooks into keyboard events via EventRewriter.
>
> This solution has some advantages. It means that we can swap the format and use keys not allowed by the commands API. Also, we can implement more features such as sequencing, or sticky key natively.
>
> Some disadvantages are it will interfere with Chrome OS sticky keys and is Chrome OS specific.
>
> TEST=ensure chrome.commands.onCommand gets called with appropriate command name when keys are struck on OOBE, locked screen, login screen, and logged in.
>
> Committed: https://crrev.com/a97769b865c7a511229d2eee04051d59200bf1b3
> Cr-Commit-Position: refs/heads/master@{#335997}
TBR=dmazzoni@chromium.org,finnur@chromium.org,oshima@chromium.org,sadrul@chromium.org,dtseng@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/1211003002
Cr-Commit-Position: refs/heads/master@{#336172}
Diffstat (limited to 'chrome/chrome_browser_chromeos.gypi')
| -rw-r--r-- | chrome/chrome_browser_chromeos.gypi | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/chrome/chrome_browser_chromeos.gypi b/chrome/chrome_browser_chromeos.gypi index 51996a4..924a2c5 100644 --- a/chrome/chrome_browser_chromeos.gypi +++ b/chrome/chrome_browser_chromeos.gypi @@ -15,8 +15,6 @@ 'browser/chromeos/accessibility/accessibility_util.h', 'browser/chromeos/accessibility/magnification_manager.cc', 'browser/chromeos/accessibility/magnification_manager.h', - 'browser/chromeos/accessibility/spoken_feedback_event_rewriter.cc', - 'browser/chromeos/accessibility/spoken_feedback_event_rewriter.h', 'browser/chromeos/app_mode/app_launch_utils.cc', 'browser/chromeos/app_mode/app_launch_utils.h', 'browser/chromeos/app_mode/app_session_lifetime.cc', |