diff options
| author | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-12 00:29:58 +0000 |
|---|---|---|
| committer | sadrul@chromium.org <sadrul@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-03-12 00:29:58 +0000 |
| commit | d10f5ae36b4ff727fe78ed10c9ca5673ad36fcb2 (patch) | |
| tree | 493e30615d2f3f8353884d89d0bbe7a71aab44b0 /chrome/chrome_browser_ui.gypi | |
| parent | 6c16475940a16572e1ecd093b96f6ad1e282725a (diff) | |
| download | chromium_src-d10f5ae36b4ff727fe78ed10c9ca5673ad36fcb2.zip chromium_src-d10f5ae36b4ff727fe78ed10c9ca5673ad36fcb2.tar.gz chromium_src-d10f5ae36b4ff727fe78ed10c9ca5673ad36fcb2.tar.bz2 | |
chromeos: Simplify how chrome keeps track of caps lock state.
Notable changes:
* Make caps-lock related tray-item explicitly chromeos-only, since there has
never been an implementation of CapsLockDelegate for other platforms.
* As a result, have the tray-item directly communicate with XKeyboard, instead
of needing the CapsLockDelegate, so delete it.
* Have the code that needs to know when the caps-lock state changes (e.g.
TrayCapsLock, SigninScreenHandler) use a pre-target handler on Shell
and look for VKEY_CAPITAL key-press events. This simplifies the code,
which currently flows from:
X11 -> SystemKeyEventListener -> SystemTrayDelegate -> SystemTrayNotifier -> TrayCapsLock
to:
X11 -> WindowTreeHost -> TrayCapsLock
BUG=none
R=derat@chromium.org, oshima@chromium.org, yusukes@chromium.org
TBR=nkostylev@chromium.org for c/b/ui/webui/chromeos/login changes
Review URL: https://codereview.chromium.org/192293004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256363 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_browser_ui.gypi')
| -rw-r--r-- | chrome/chrome_browser_ui.gypi | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi index ee88496..0675482 100644 --- a/chrome/chrome_browser_ui.gypi +++ b/chrome/chrome_browser_ui.gypi @@ -278,10 +278,6 @@ 'browser/ui/ash/ash_init.h', 'browser/ui/ash/ash_util.cc', 'browser/ui/ash/ash_util.h', - 'browser/ui/ash/caps_lock_delegate_chromeos.cc', - 'browser/ui/ash/caps_lock_delegate_chromeos.h', - 'browser/ui/ash/caps_lock_delegate_views.cc', - 'browser/ui/ash/caps_lock_delegate_views.h', 'browser/ui/ash/chrome_launcher_prefs.cc', 'browser/ui/ash/chrome_launcher_prefs.h', 'browser/ui/ash/chrome_new_window_delegate.cc', @@ -2843,7 +2839,6 @@ 'browser_chromeos', ], 'sources!': [ - 'browser/ui/ash/caps_lock_delegate_views.cc', 'browser/ui/ash/chrome_shell_delegate_views.cc', 'browser/ui/ash/multi_user/multi_user_context_menu.cc', 'browser/ui/ash/session_state_delegate_views.cc', |