diff options
| author | rvargas <rvargas@chromium.org> | 2014-08-26 12:45:42 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-08-26 19:48:38 +0000 |
| commit | 1a4d07b227c51e2010867b3af70b2a58e7f01ad5 (patch) | |
| tree | b1710b6032f5567d1ac6392705676c6356c906a9 /chrome/chrome_dll.gypi | |
| parent | 67769df5422bdf01a8d4a21f18fed694bec03647 (diff) | |
| download | chromium_src-1a4d07b227c51e2010867b3af70b2a58e7f01ad5.zip chromium_src-1a4d07b227c51e2010867b3af70b2a58e7f01ad5.tar.gz chromium_src-1a4d07b227c51e2010867b3af70b2a58e7f01ad5.tar.bz2 | |
Improve the ScopedHandle verifier.
1. Automate the selection of the proper channel to enable the verifier.
Now the code is enabled at runtime.
2. Switch to a hash_map to track handles.
3. Intercept CloseHandle to detect the code that is closing handles owned
by ScopedHandles. The initial implementation only covers chrome.exe/dll,
but the plan is to extend that in the future to all modules loaded in the
process.
BUG=362176
R=cpu@chromium.org
R=sky@chromium.org
See https://codereview.chromium.org/490043002/ for the actual review.
TBR=cpu@chromium.org
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/506013004
Cr-Commit-Position: refs/heads/master@{#291969}
Diffstat (limited to 'chrome/chrome_dll.gypi')
| -rw-r--r-- | chrome/chrome_dll.gypi | 35 |
1 files changed, 17 insertions, 18 deletions
diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi index bc3baf5..72f5024 100644 --- a/chrome/chrome_dll.gypi +++ b/chrome/chrome_dll.gypi @@ -77,6 +77,20 @@ 'variables': { 'enable_wexit_time_destructors': 1, }, + 'sources': [ + 'app/chrome_command_ids.h', + 'app/chrome_dll_resource.h', + 'app/chrome_main.cc', + 'app/chrome_main_delegate.cc', + 'app/chrome_main_delegate.h', + 'app/chrome_main_mac.mm', + 'app/chrome_main_mac.h', + 'app/close_handle_hook_win.cc', + 'app/close_handle_hook_win.h', + 'app/delay_load_hook_win.cc', + 'app/delay_load_hook_win.h', + '../base/win/dllmain.cc', + ], 'dependencies': [ '<@(chromium_browser_dependencies)', '../content/content.gyp:content_app_browser', @@ -117,17 +131,9 @@ '../ui/views/views.gyp:views', ], 'sources': [ - 'app/chrome_command_ids.h', 'app/chrome_dll.rc', - 'app/chrome_dll_resource.h', - 'app/chrome_main.cc', - 'app/chrome_main_delegate.cc', - 'app/chrome_main_delegate.h', - 'app/delay_load_hook_win.cc', - 'app/delay_load_hook_win.h', - + '<(SHARED_INTERMEDIATE_DIR)/chrome_version/chrome_dll_version.rc', - '../base/win/dllmain.cc', # Cursors. '<(SHARED_INTERMEDIATE_DIR)/ui/resources/ui_unscaled_resources.rc', @@ -272,15 +278,6 @@ # sets -order_file. 'ORDER_FILE': 'app/framework.order', }, - 'sources': [ - 'app/chrome_command_ids.h', - 'app/chrome_dll_resource.h', - 'app/chrome_main.cc', - 'app/chrome_main_delegate.cc', - 'app/chrome_main_delegate.h', - 'app/chrome_main_mac.mm', - 'app/chrome_main_mac.h', - ], 'dependencies': [ '../pdf/pdf.gyp:pdf', ], @@ -350,6 +347,8 @@ 'app/chrome_main.cc', 'app/chrome_main_delegate.cc', 'app/chrome_main_delegate.h', + 'app/close_handle_hook_win.cc', + 'app/close_handle_hook_win.h', ], 'conditions': [ ['OS=="win"', { |