diff options
| author | scottmg <scottmg@chromium.org> | 2015-11-25 13:55:47 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-11-25 21:57:07 +0000 |
| commit | aaa2ff656f9fcabcbdd9e9964e3b2bdc8f5102ed (patch) | |
| tree | 28f1fef91043cd3f7a30c85ce59e56b057102207 /chrome/chrome_dll.gypi | |
| parent | cbc1cd295bc85219ad89326457cd7f5cf003d41c (diff) | |
| download | chromium_src-aaa2ff656f9fcabcbdd9e9964e3b2bdc8f5102ed.zip chromium_src-aaa2ff656f9fcabcbdd9e9964e3b2bdc8f5102ed.tar.gz chromium_src-aaa2ff656f9fcabcbdd9e9964e3b2bdc8f5102ed.tar.bz2 | |
Crashpad Windows: Use the Crashpad client instead of Breakpad on Windows
Crashpad is always compiled into chrome and its handler is always
enabled. It only uploads in Official builds.
On Windows, the crash handler is chrome.exe run with a
--crashpad-handler argument. This is due to concern about
incompatibilities of shipping an additional new different binary for AV,
firewalls, etc.
Sample renderer crash/1aed2bc785e28995
Sample browser: crash/66c822815474a5d8
See also http://crbug.com/427611 .
R=mark@chromium.org,cpu@chromium.org
BUG=447073,546288, 456193
Review URL: https://codereview.chromium.org/1416133003
Cr-Commit-Position: refs/heads/master@{#361742}
Diffstat (limited to 'chrome/chrome_dll.gypi')
| -rw-r--r-- | chrome/chrome_dll.gypi | 13 |
1 files changed, 13 insertions, 0 deletions
diff --git a/chrome/chrome_dll.gypi b/chrome/chrome_dll.gypi index 0ea9690..09c93d5 100644 --- a/chrome/chrome_dll.gypi +++ b/chrome/chrome_dll.gypi @@ -123,7 +123,9 @@ ], 'dependencies': [ '<@(chromium_browser_dependencies)', + '../components/components.gyp:crash_component', '../content/content.gyp:content_app_browser', + '../third_party/crashpad/crashpad/handler/handler.gyp:crashpad_handler', ], 'conditions': [ ['OS=="win"', { @@ -163,6 +165,8 @@ ], 'sources': [ 'app/chrome_dll.rc', + 'app/chrome_crash_reporter_client.cc', + 'app/chrome_crash_reporter_client.h', # ETW Manifest. '<(SHARED_INTERMEDIATE_DIR)/base/trace_event/etw_manifest/chrome_events_win.rc', @@ -350,6 +354,8 @@ }, 'dependencies': [ '<@(chromium_child_dependencies)', + '../components/components.gyp:browser_watcher_client', + '../components/components.gyp:crash_component', '../content/content.gyp:content_app_child', 'chrome_version_resources', 'policy_path_parser', @@ -359,6 +365,8 @@ ], 'sources': [ '<(SHARED_INTERMEDIATE_DIR)/chrome_version/chrome_dll_version.rc', + 'app/chrome_crash_reporter_client.cc', + 'app/chrome_crash_reporter_client.h', 'app/chrome_main.cc', 'app/chrome_main_delegate.cc', 'app/chrome_main_delegate.h', @@ -392,6 +400,11 @@ }], ] }], + ['OS=="win" and configuration_policy==1', { + 'dependencies': [ + '<(DEPTH)/components/components.gyp:policy', + ], + }], ['enable_plugins==1', { 'dependencies': [ '../pdf/pdf.gyp:pdf', |