diff options
| author | rsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-01 23:20:09 +0000 |
|---|---|---|
| committer | rsesek@chromium.org <rsesek@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-08-01 23:20:09 +0000 |
| commit | 1bb578db2735d5c8074220e9c4d7fb32d5a9f244 (patch) | |
| tree | e0eaad8a29ddad8119901344a213282b906a5c89 /chrome/chrome_exe.gypi | |
| parent | 2a6fd37fe4e8f471895b8dfac95c4738d3ed52c4 (diff) | |
| download | chromium_src-1bb578db2735d5c8074220e9c4d7fb32d5a9f244.zip chromium_src-1bb578db2735d5c8074220e9c4d7fb32d5a9f244.tar.gz chromium_src-1bb578db2735d5c8074220e9c4d7fb32d5a9f244.tar.bz2 | |
Do not pass -dead_strip to ld for the Mac helper and main apps.
On certain SDK versions and OSes with the 10.6 deployment target, the linker, if
invoked with -dead_strip, incorrectly removes _NXArgc and _NXArgv. Since the
apps are just shims into the Framework, there's little to strip anyways.
BUG=139902
TEST=Build on 10.7+ with GYP variable mac_strip_release=1.
Review URL: https://chromiumcodereview.appspot.com/10830126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149531 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_exe.gypi')
| -rw-r--r-- | chrome/chrome_exe.gypi | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi index c34c2af..c9d15fe 100644 --- a/chrome/chrome_exe.gypi +++ b/chrome/chrome_exe.gypi @@ -247,6 +247,16 @@ 'CHROMIUM_CREATOR': '<(mac_creator)', 'CHROMIUM_SHORT_NAME': '<(branding)', }, + # Turn off -dead_strip in Release mode for the main app. There's + # little here to strip, and doing so preserves symbols from + # crt1.10.6.o, which get removed incorrectly. http://crbug.com/139902 + 'configurations': { + 'Release': { + 'xcode_settings': { + 'DEAD_CODE_STRIPPING': 'NO', + }, + }, + }, 'dependencies': [ 'helper_app', 'infoplist_strings_tool', |