diff options
| author | glider <glider@chromium.org> | 2014-09-01 06:42:34 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-01 13:45:26 +0000 |
| commit | 5750a97fd179642548e6add77aafc1cdb0eec7e8 (patch) | |
| tree | 379d6de68e9ebf977d713a15f8c42b7da981301a /chrome/chrome_exe.gypi | |
| parent | 64e080e5ab8c89dd05afb6cd6d3887054b7c0a39 (diff) | |
| download | chromium_src-5750a97fd179642548e6add77aafc1cdb0eec7e8.zip chromium_src-5750a97fd179642548e6add77aafc1cdb0eec7e8.tar.gz chromium_src-5750a97fd179642548e6add77aafc1cdb0eec7e8.tar.bz2 | |
Reland https://codereview.chromium.org/298333007/: Enable mac_strip_release under ASan on OSX. Remove the .saves files.
The reasons for reverting the CL hadn't been documented. I'm going to reland and update the bugs.
Unce upon a time the ASan runtime library used to be statically linked into
the executables on OSX.
Because that library provided a number of API functions needed by the shared
libraries, we had custom ASan-specific .saves files that told the `strip`
utility to preserve those functions when stripping the executables.
Then ASan switched to using dynamic runtime library, which instantly broke the
stripping step, because the executables weren't necessarily referencing all the
ASan API functions (issue 242503).
As a result, stripping has been disabled, and we haven't had .dSYM debug info
for ASan builds for more than a year now (issue 148383).
Because the ASan API functions are now undefined in the executables, it's
actually senseless to use the .saves files to preserve those functions.
This CL deletes the .saves files and turns mac_strip_release on for ASan
builds.
BUG=148383, 242503, 170739, 166857
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/517803004
Cr-Commit-Position: refs/heads/master@{#292872}
Diffstat (limited to 'chrome/chrome_exe.gypi')
| -rw-r--r-- | chrome/chrome_exe.gypi | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chrome/chrome_exe.gypi b/chrome/chrome_exe.gypi index 6044979..a8e4f3a 100644 --- a/chrome/chrome_exe.gypi +++ b/chrome/chrome_exe.gypi @@ -458,12 +458,6 @@ ['chrome_multiple_dll', { 'defines': ['CHROME_MULTIPLE_DLL'], }], - ['OS=="mac" and asan==1', { - 'xcode_settings': { - # Override the outer definition of CHROMIUM_STRIP_SAVE_FILE. - 'CHROMIUM_STRIP_SAVE_FILE': 'app/app_asan.saves', - }, - }], ['OS=="linux"', { 'conditions': [ ['branding=="Chrome"', { |