diff options
| author | huangs@chromium.org <huangs@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-28 19:40:41 +0000 |
|---|---|---|
| committer | huangs@chromium.org <huangs@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-05-28 19:40:41 +0000 |
| commit | f8df93d24227358ad16c96c013b71cd5f0e7d62d (patch) | |
| tree | 9abc8cdc8f26fd3e71311f67d83bd3c533a3f723 /chrome/chrome_installer_util.gypi | |
| parent | 3815ddd65b5efcd8c9522e740990b2bc10cfb307 (diff) | |
| download | chromium_src-f8df93d24227358ad16c96c013b71cd5f0e7d62d.zip chromium_src-f8df93d24227358ad16c96c013b71cd5f0e7d62d.tar.gz chromium_src-f8df93d24227358ad16c96c013b71cd5f0e7d62d.tar.bz2 | |
Refactor: Extracting base interface from BrowserDistribution to simplify Google Update registry writes.
The following member functions of BrowserDistribution:
- GetAppGuid(),
- GetStateKey(),
- GetStateMediumKey(),
- GetVersionKey(),
are extracted to a new interface AppRegistrationData, which is then made a member of BrowserDistribution.
To prevent massive changes existing code, the extracted routines are kept in BrowserDistribution as adaptors to the AppRegistrationData within.
Next, calls related to setting the "did-run" flags are refactored to take AppRegistrationData instead of BrowserDistribution. This is to help us remove ChromeAppHostDistribution, since now we just have to implement AppRegistrationData.
Also, changes in google_update_settings:
- UpdateDidRunStateForDistribution() => UpdateDidRunStateForApp().
- Added UpdateDidRunStateForBinaries().
- Logic changes regarding multi_install, affecting App Launcher caller.
BUG=297647
Review URL: https://codereview.chromium.org/252893005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273321 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_installer_util.gypi')
| -rw-r--r-- | chrome/chrome_installer_util.gypi | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/chrome/chrome_installer_util.gypi b/chrome/chrome_installer_util.gypi index 0faebd7..af05c26 100644 --- a/chrome/chrome_installer_util.gypi +++ b/chrome/chrome_installer_util.gypi @@ -17,6 +17,7 @@ 'installer/util/app_command.h', 'installer/util/app_commands.cc', 'installer/util/app_commands.h', + 'installer/util/app_registration_data.h', 'installer/util/auto_launch_util.cc', 'installer/util/auto_launch_util.h', 'installer/util/browser_distribution.cc', @@ -79,12 +80,16 @@ 'installer/util/master_preferences_constants.h', 'installer/util/move_tree_work_item.cc', 'installer/util/move_tree_work_item.h', + 'installer/util/non_updating_app_registration_data.h', + 'installer/util/non_updating_app_registration_data.cc', 'installer/util/registry_key_backup.cc', 'installer/util/registry_key_backup.h', 'installer/util/self_reg_work_item.cc', 'installer/util/self_reg_work_item.h', 'installer/util/set_reg_value_work_item.cc', 'installer/util/set_reg_value_work_item.h', + 'installer/util/updating_app_registration_data.h', + 'installer/util/updating_app_registration_data.cc', 'installer/util/util_constants.cc', 'installer/util/util_constants.h', 'installer/util/wmi.cc', |