diff options
| author | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-06 22:33:12 +0000 |
|---|---|---|
| committer | sail@chromium.org <sail@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-02-06 22:33:12 +0000 |
| commit | 8aa690c1efe614daadf794825c5e97ff2b928ffc (patch) | |
| tree | 3498e0f2e4ce7ea9927439bd09268939d22240b2 /chrome/chrome_nibs.gyp | |
| parent | f53977445e51f7c2e62539891fbf55d9b6989fa7 (diff) | |
| download | chromium_src-8aa690c1efe614daadf794825c5e97ff2b928ffc.zip chromium_src-8aa690c1efe614daadf794825c5e97ff2b928ffc.tar.gz chromium_src-8aa690c1efe614daadf794825c5e97ff2b928ffc.tar.bz2 | |
Mac: One click signin dialog
This is the Mac version of this Views CL:
https://codereview.chromium.org/11896021/
Currently the one click signin confirmation UI is implemented as a
bubble. This CL adds a tab modal dialog version of that UI.
Code common to the dialog and bubble has been moved to a new OneClickSigninViewController class.
XIB Changes:
OneClickSigninBubble.xib:
* aligned the baseline of the text in the advanced link with the
text in the OK button.
* changed the file owner to be OneClickSigninViewController
OneClickSigninDialog.xib
* same as OneClickSigninBubble.xib except it uses constrained
window sytle controls
Screenshots:
Bubble: http://i.imgur.com/HmJqoQk.png
Dialog: http://i.imgur.com/gaY2cym.png
BUG=171330
TEST=
To show the bubble I performed the following steps;
- ran chrome with --use-client-login-signin-flow
- signed into gmail
- clicked "Ok Sync" in the infobar
Testing the dialog requires access to server side stuff that's not public yet. I asked rogerta@ for instructions.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181056
Review URL: https://codereview.chromium.org/12082088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181071 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_nibs.gyp')
| -rw-r--r-- | chrome/chrome_nibs.gyp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/chrome_nibs.gyp b/chrome/chrome_nibs.gyp index 8d2bbc6..3879c90 100644 --- a/chrome/chrome_nibs.gyp +++ b/chrome/chrome_nibs.gyp @@ -211,8 +211,8 @@ 'browser/ui/cocoa/nsmenuitem_additions.mm', 'browser/ui/cocoa/nsview_additions.h', 'browser/ui/cocoa/nsview_additions.mm', - 'browser/ui/cocoa/one_click_signin_bubble_controller.h', - 'browser/ui/cocoa/one_click_signin_bubble_controller.mm', + 'browser/ui/cocoa/one_click_signin_view_controller.h', + 'browser/ui/cocoa/one_click_signin_view_controller.mm', 'browser/ui/cocoa/speech_recognition_window_controller.h', 'browser/ui/cocoa/speech_recognition_window_controller.mm', 'browser/ui/cocoa/status_bubble_mac.h', |