diff options
| author | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-21 21:21:22 +0000 |
|---|---|---|
| committer | aa@chromium.org <aa@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-08-21 21:21:22 +0000 |
| commit | bad77bf7b76ecaa884dd1cba56eeefd94e219c30 (patch) | |
| tree | aad2c74d15403b87d2a098b1a7242776844a48d9 /chrome/chrome_tests.gypi | |
| parent | 62283a891ee9e9f5e775674c33e3225ea6885abf (diff) | |
| download | chromium_src-bad77bf7b76ecaa884dd1cba56eeefd94e219c30.zip chromium_src-bad77bf7b76ecaa884dd1cba56eeefd94e219c30.tar.gz chromium_src-bad77bf7b76ecaa884dd1cba56eeefd94e219c30.tar.bz2 | |
Remove attempt to be smart about where to open navigations
targetting app tabs. I futzed with this a bit to try and
integrate installed apps extents, but it is complex.
Also, I looked over the original bug where this code was
added: crbug.com/29281. The issue there was that when you
click on a bookmark (presumably in the bookmark bar) the
pinned tab is unexpectedly overwritten. I can see that
complaint, but there is also the use case of clicking
a bookmark and intending it to overwrite the pinned tab.
In summary, I kinda feel like the expectations about
how navigation should work are too ingrained and we
shouldn't be meddling.
BUG=52680
Review URL: http://codereview.chromium.org/3161037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57002 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/chrome_tests.gypi')
| -rw-r--r-- | chrome/chrome_tests.gypi | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 6323db8..1abf452 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -844,7 +844,6 @@ 'browser/browser_commands_unittest.cc', 'browser/browser_theme_pack_unittest.cc', 'browser/browser_theme_provider_unittest.cc', - 'browser/browser_unittest.cc', 'browser/browsing_data_appcache_helper_unittest.cc', 'browser/browsing_data_database_helper_unittest.cc', 'browser/browsing_data_local_storage_helper_unittest.cc', |