diff options
author | jam <jam@chromium.org> | 2014-09-03 20:26:58 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2014-09-04 03:29:06 +0000 |
commit | 6de6c6eaee01e8aa52e3e380fc2fcd1cc1ef2445 (patch) | |
tree | cb92e320c111aa3b95dd48718d5acd22bd9d820e /chrome/chrome_tests.gypi | |
parent | f5186515e0607b24d77a0bca13634f0158865b8e (diff) | |
download | chromium_src-6de6c6eaee01e8aa52e3e380fc2fcd1cc1ef2445.zip chromium_src-6de6c6eaee01e8aa52e3e380fc2fcd1cc1ef2445.tar.gz chromium_src-6de6c6eaee01e8aa52e3e380fc2fcd1cc1ef2445.tar.bz2 |
Revert of Add LocationBar PageAction tests (patchset #4 id:80001 of https://codereview.chromium.org/512693003/)
Reason for revert:
Flaky test
see the following runs where the test fails even with 3 retries
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9713
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9656
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9574
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9511
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9405
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9367
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9252
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9253
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9223
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/9213
Original issue's description:
> Add LocationBar PageAction tests
>
> Page actions in the location bar have been somewhat loosely tested as a side-
> effect of the page actions api testing, but (near as I can tell), we never
> explicity test the ui for page actions.
>
> This is a problem because the extensions tests shouldn't care about the UI, and
> soon won't, since where the page actions are in the UI may change (i.e.,
> location bar vs toolbar).
>
> Fix this by adding a few basic UI tests for page actions in the location bar.
>
> BUG=408261
>
> Committed: https://chromium.googlesource.com/chromium/src/+/0abaca08e99fa6671758a96829b99aa941696e41
TBR=finnur@chromium.org,sky@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=408261
Review URL: https://codereview.chromium.org/537813002
Cr-Commit-Position: refs/heads/master@{#293253}
Diffstat (limited to 'chrome/chrome_tests.gypi')
-rw-r--r-- | chrome/chrome_tests.gypi | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 3227fc3..df75d18 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -1460,7 +1460,6 @@ 'browser/ui/fullscreen/fullscreen_controller_browsertest.cc', 'browser/ui/global_error/global_error_service_browsertest.cc', 'browser/ui/login/login_prompt_browsertest.cc', - 'browser/ui/location_bar/location_bar_browsertest.cc', 'browser/ui/panels/panel_extension_browsertest.cc', 'browser/ui/passwords/manage_passwords_test.cc', 'browser/ui/pdf/pdf_browsertest.cc', |