diff options
| author | jam <jam@chromium.org> | 2014-08-25 13:42:52 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-08-25 21:00:49 +0000 |
| commit | e8e38740e5ab846889016636024309473c04dedd (patch) | |
| tree | ff717bb445e5a42f2ca84067e87946104520cb2f /chrome/chrome_tests.gypi | |
| parent | cf57e8b1ea2b1f75d1ac3d74c52a85f4951c590e (diff) | |
| download | chromium_src-e8e38740e5ab846889016636024309473c04dedd.zip chromium_src-e8e38740e5ab846889016636024309473c04dedd.tar.gz chromium_src-e8e38740e5ab846889016636024309473c04dedd.tar.bz2 | |
Revert of Hook up the Mac password bubble to the browser and add browser tests. (patchset #8 of https://codereview.chromium.org/444603003/)
Reason for revert:
the browser tests this added are really flaky on the trybots.
see
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6541
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6582
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6576
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6574
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6573
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6572
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6567
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6566
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6565
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6564
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6561
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6557
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6556
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6554
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6554
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6549
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6548
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6544
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6544
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6541
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6539
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6537
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/6530
please test this on many try runs before relanding.
Original issue's description:
> Hook up the Mac password bubble to the browser and add browser tests.
>
> BUG=328847
>
> Committed: https://chromium.googlesource.com/chromium/src/+/dae2a9adff280655fa9261b972fd62ae837b374d
TBR=dconnelly
NOTRY=true
Review URL: https://codereview.chromium.org/473423005
Cr-Commit-Position: refs/heads/master@{#291755}
Diffstat (limited to 'chrome/chrome_tests.gypi')
| -rw-r--r-- | chrome/chrome_tests.gypi | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index aeae697..940fc9a 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -111,8 +111,6 @@ 'browser/ui/panels/test_panel_notification_observer.h', 'browser/ui/panels/test_panel_collection_squeeze_observer.cc', 'browser/ui/panels/test_panel_collection_squeeze_observer.h', - 'browser/ui/passwords/manage_passwords_test.cc', - 'browser/ui/passwords/manage_passwords_test.h', 'browser/ui/search/instant_extended_interactive_uitest.cc', 'browser/ui/pdf/pdf_interactive_browsertest.cc', 'browser/ui/search/instant_extended_manual_interactive_uitest.cc', @@ -140,6 +138,8 @@ 'browser/ui/views/message_center/web_notification_tray_browsertest.cc', 'browser/ui/views/omnibox/omnibox_view_views_browsertest.cc', 'browser/ui/views/panels/panel_view_browsertest.cc', + 'browser/ui/views/passwords/manage_passwords_view_test.cc', + 'browser/ui/views/passwords/manage_passwords_view_test.h', 'browser/ui/views/passwords/manage_passwords_bubble_view_browsertest.cc', 'browser/ui/views/passwords/manage_passwords_icon_view_browsertest.cc', 'browser/ui/views/ssl_client_certificate_selector_browsertest.cc', @@ -1450,7 +1450,6 @@ 'browser/ui/cocoa/omnibox/omnibox_view_mac_browsertest.mm', 'browser/ui/cocoa/one_click_signin_bubble_controller_browsertest.mm', 'browser/ui/cocoa/one_click_signin_dialog_controller_browsertest.mm', - 'browser/ui/cocoa/passwords/manage_passwords_bubble_browsertest.mm', 'browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm', 'browser/ui/cocoa/ssl_client_certificate_selector_cocoa_browsertest.mm', 'browser/ui/cocoa/view_id_util_browsertest.mm', @@ -1460,7 +1459,6 @@ 'browser/ui/global_error/global_error_service_browsertest.cc', 'browser/ui/login/login_prompt_browsertest.cc', 'browser/ui/panels/panel_extension_browsertest.cc', - 'browser/ui/passwords/manage_passwords_test.cc', 'browser/ui/pdf/pdf_browsertest.cc', 'browser/ui/prefs/prefs_tab_helper_browsertest.cc', 'browser/ui/settings_window_manager_browsertest.cc', |