diff options
| author | jabdelmalek <jabdelmalek@google.com> | 2014-08-26 08:59:59 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-08-26 16:01:30 +0000 |
| commit | fe0013537c9d2554a97a3e752f5d1dd417b5cf59 (patch) | |
| tree | 6773275c5d5f9c0fa16ff3aeb7683b835b12b476 /chrome/chrome_tests.gypi | |
| parent | ac2715c66e674556caeb648a81877dcf42bced6a (diff) | |
| download | chromium_src-fe0013537c9d2554a97a3e752f5d1dd417b5cf59.zip chromium_src-fe0013537c9d2554a97a3e752f5d1dd417b5cf59.tar.gz chromium_src-fe0013537c9d2554a97a3e752f5d1dd417b5cf59.tar.bz2 | |
Revert of Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable. (patchset #1 of https://codereview.chromium.org/492623003/)
Reason for revert:
Causing huge amounts of flake even with retries, see these jobs that failed on the CQ.
Please don't renable without watching the trybots closely to make sure it's not causing a lot of failures: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming?numbuilds=200
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5716
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5716
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5696
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5688
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5685
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5680
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5678
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5675
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5673
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5671
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5667
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5666
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5665
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5663
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5661
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5661
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5660
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5647
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5644
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5643
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5637
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/5639
Original issue's description:
> Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable.
>
> This test was flaky because it modified system properties. Moving it to
> interactive_ui_tests should allow it the system control guarantees it
> needs to complete successfully.
>
> BUG=396344
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4d5d5d700a104f5e6bec47a8891fc5a54a4f242b
TBR=sky@chromium.org,calamity@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=396344
Review URL: https://codereview.chromium.org/504253002
Cr-Commit-Position: refs/heads/master@{#291913}
Diffstat (limited to 'chrome/chrome_tests.gypi')
| -rw-r--r-- | chrome/chrome_tests.gypi | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/chrome_tests.gypi b/chrome/chrome_tests.gypi index 2b1eb2f..940fc9a 100644 --- a/chrome/chrome_tests.gypi +++ b/chrome/chrome_tests.gypi @@ -127,7 +127,6 @@ 'browser/ui/views/find_bar_host_interactive_uitest.cc', 'browser/ui/views/frame/browser_view_focus_uitest.cc', 'browser/ui/views/frame/browser_view_interactive_uitest.cc', - 'browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc', 'browser/ui/views/keyboard_access_browsertest.cc', 'browser/ui/views/location_bar/star_view_browsertest.cc', 'browser/ui/views/menu_controller_interactive_uitest.cc', @@ -1478,6 +1477,7 @@ 'browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc', 'browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc', 'browser/ui/views/frame/browser_view_browsertest.cc', + 'browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc', 'browser/ui/views/location_bar/zoom_bubble_view_browsertest.cc', 'browser/ui/views/profiles/avatar_menu_button_browsertest.cc', 'browser/ui/views/profiles/new_avatar_menu_button_browsertest.cc', |