diff options
| author | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
|---|---|---|
| committer | brettw@chromium.org <brettw@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-30 19:28:44 +0000 |
| commit | 528c56de01bbbd38788ed6cf8d2eea4c56cbe19e (patch) | |
| tree | ac4f7a001affd772c4ab89701d3d46109b5f9e19 /chrome/common/child_process.cc | |
| parent | 5c86ada8d84f6e67d17b027d347052ef451241c4 (diff) | |
| download | chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.zip chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.gz chromium_src-528c56de01bbbd38788ed6cf8d2eea4c56cbe19e.tar.bz2 | |
Move the number conversions from string_util to a new file.
Use the base namespace in the new file. Update callers.
I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.
TEST=included unit tests
BUG=none
Review URL: http://codereview.chromium.org/3056029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/child_process.cc')
| -rw-r--r-- | chrome/common/child_process.cc | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/common/child_process.cc b/chrome/common/child_process.cc index 71d025a..e64f0f3 100644 --- a/chrome/common/child_process.cc +++ b/chrome/common/child_process.cc @@ -11,8 +11,9 @@ #include "app/l10n_util.h" #include "base/message_loop.h" #include "base/process_util.h" -#include "base/string_util.h" +#include "base/string_number_conversions.h" #include "base/thread.h" +#include "base/utf_string_conversions.h" #include "chrome/common/child_thread.h" #include "grit/chromium_strings.h" @@ -76,7 +77,7 @@ void ChildProcess::WaitForDebugger(const std::wstring& label) { std::wstring title = l10n_util::GetString(IDS_PRODUCT_NAME); std::wstring message = label; message += L" starting with pid: "; - message += IntToWString(base::GetCurrentProcId()); + message += UTF8ToWide(base::IntToString(base::GetCurrentProcId())); title += L" "; title += label; // makes attaching to process easier ::MessageBox(NULL, message.c_str(), title.c_str(), |