summaryrefslogtreecommitdiffstats
path: root/chrome/common/child_process_host.h
diff options
context:
space:
mode:
authormark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-15 02:04:21 +0000
committermark@chromium.org <mark@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2009-08-15 02:04:21 +0000
commit0abe2cbeb51078bf2f14496fac9a1d7a2e21a919 (patch)
tree17cbd45a663de156b1d1f15f9c3d855a9d2782d5 /chrome/common/child_process_host.h
parentd0620522264c47074c3602fa8dfb7ad5fbf64e64 (diff)
downloadchromium_src-0abe2cbeb51078bf2f14496fac9a1d7a2e21a919.zip
chromium_src-0abe2cbeb51078bf2f14496fac9a1d7a2e21a919.tar.gz
chromium_src-0abe2cbeb51078bf2f14496fac9a1d7a2e21a919.tar.bz2
Change breakpads on the helper processes to keep our rimZ clean.
Initialize crash reporting in helper processes such as the renderer process. Renderer crash reporting stopped working in r23006 when multiple .app bundles were introduced, because the stats collection and crash reporting preference is presently accessed via NSUserDefaults, keyed on the bundle ID. The main browser process and helper processes have distinct bundle IDs. In the new scheme, only the main browser process consults this preference, and passes it to helper processes in their command lines. BUG=19204 TEST=When reporting is enabled, Breakpad should pick up browser and renderer process crashes; When reporting is enabled, renderer should not log messages like [mmdd/hhmmss:WARNING:/path/to/breakpad_mac.mm(47)] Breakpad disabled; When reporting is disabled, browser and renderer should both log these messages. Review URL: http://codereview.chromium.org/165546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23509 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/child_process_host.h')
-rw-r--r--chrome/common/child_process_host.h8
1 files changed, 8 insertions, 0 deletions
diff --git a/chrome/common/child_process_host.h b/chrome/common/child_process_host.h
index 95b97b6..cb833dc 100644
--- a/chrome/common/child_process_host.h
+++ b/chrome/common/child_process_host.h
@@ -13,6 +13,7 @@
#include "chrome/browser/renderer_host/resource_dispatcher_host.h"
#include "ipc/ipc_channel.h"
+class CommandLine;
class NotificationType;
// Plugins/workers and other child processes that live on the IO thread should
@@ -29,6 +30,13 @@ class ChildProcessHost : public ResourceDispatcherHost::Receiver,
// returns an empty wstring.
static std::wstring GetChildPath();
+ // Prepares command_line for crash reporting as appropriate. On Linux and
+ // Mac, a command-line flag to enable crash reporting in the child process
+ // will be appended if needed, because the child process may not have access
+ // to the data that determines the status of crash reporting in the
+ // currently-executing process. This function is a no-op on Windows.
+ static void SetCrashReporterCommandLine(CommandLine* command_line);
+
// ResourceDispatcherHost::Receiver implementation:
virtual bool Send(IPC::Message* msg);