diff options
| author | jcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-22 21:24:17 +0000 |
|---|---|---|
| committer | jcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-07-22 21:24:17 +0000 |
| commit | 655f97c3163034d8f5967c75f320b1eff4ec108d (patch) | |
| tree | 11f72fa50e2dc46e904cdd9efa25225de85b01d2 /chrome/common/chrome_constants.cc | |
| parent | 6464e051fdb35c41c7a3673a03b04d26123b6772 (diff) | |
| download | chromium_src-655f97c3163034d8f5967c75f320b1eff4ec108d.zip chromium_src-655f97c3163034d8f5967c75f320b1eff4ec108d.tar.gz chromium_src-655f97c3163034d8f5967c75f320b1eff4ec108d.tar.bz2 | |
Few TranslateManager changes:
- Always show a "translating..." infobar when initiating a translation from the context menu, or when the translation is automatic (always translate option). It does not make sense not to show one, as translation may take several seconds and no having any feedback during that time is confusing (also this is what translate in toolbar does).
- Don't enable the translate context menu until we get the page language. This is an effort to ensure the translate infobar delegate always get an original language.
- Makes the translate manager deals correctly with unknown languages to avoid a crasher (bug 49018)
BUG=49018
TEST=See bug. And also, start a translation from the context menu, while the page is being translated a "translating..." infobar should be shown. Also, tests that when a language was selected for "always translate", navigating to a page in that language triggers a "translating..." infobar.
Review URL: http://codereview.chromium.org/3026002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53384 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/chrome_constants.cc')
| -rw-r--r-- | chrome/common/chrome_constants.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/chrome/common/chrome_constants.cc b/chrome/common/chrome_constants.cc index 47f0d52..927f7d3 100644 --- a/chrome/common/chrome_constants.cc +++ b/chrome/common/chrome_constants.cc @@ -134,6 +134,8 @@ const int kMaxSessionHistoryEntries = 50; const wchar_t kChromiumRendererIdProperty[] = L"ChromiumRendererId"; +const char* const kUnknownLanguageCode = "und"; + } // namespace chrome #undef FPL |