summaryrefslogtreecommitdiffstats
path: root/chrome/common/descriptors_android.h
diff options
context:
space:
mode:
authorjcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-10-24 22:03:38 +0000
committerjcivelli@chromium.org <jcivelli@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2012-10-24 22:03:38 +0000
commit40da3e0c42d83eb6225d9d340780bd6e3af14b6c (patch)
treeabb3a7d5bc2db5dcdbd5031fa6acbf018e9a0652 /chrome/common/descriptors_android.h
parent4d8517ad228e3eb26bcc776c6c95dcdfeb51a31c (diff)
downloadchromium_src-40da3e0c42d83eb6225d9d340780bd6e3af14b6c.zip
chromium_src-40da3e0c42d83eb6225d9d340780bd6e3af14b6c.tar.gz
chromium_src-40da3e0c42d83eb6225d9d340780bd6e3af14b6c.tar.bz2
Because of UID isolation on Android, crash dump generation has to happen
in-process for renderers as well (as the browser cannot access all the necessary states of the renderer process). Breakpad has support for generating minidumps to a passed FD (as the renderer process on Android does not have permission to create file), so the flow on Android is: - when a render process is created the browser creates a file and passes its FD to the process - the renderer process initializes Breakpad with that FD - if there is a crash, Breakpad generates the minidump to that FD. - when the browser process detects a renderer stopped it checks the minidump file. If it's empty it deletes the file. If it's not empty, it means there was a crasher in which case it moves it to the crash dump folder for it to be picked up and uploaded by the Java side. BUG=None TEST=Test that minidumps are generated and uploaded when visiting about:crash and about:crashbrowserforrealz on Android and desktop Chrome. Review URL: https://chromiumcodereview.appspot.com/11189068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163917 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/descriptors_android.h')
-rw-r--r--chrome/common/descriptors_android.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/chrome/common/descriptors_android.h b/chrome/common/descriptors_android.h
index 0a72bac..09d9a9b 100644
--- a/chrome/common/descriptors_android.h
+++ b/chrome/common/descriptors_android.h
@@ -11,7 +11,8 @@ enum {
#if defined(OS_ANDROID)
kAndroidChromePakDescriptor = kContentIPCDescriptorMax + 1,
kAndroidLocalePakDescriptor,
- kAndroidUIResourcesPakDescriptor
+ kAndroidUIResourcesPakDescriptor,
+ kAndroidMinidumpDescriptor,
#endif
};