diff options
| author | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-14 22:29:03 +0000 |
|---|---|---|
| committer | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-02-14 22:29:03 +0000 |
| commit | 6bd1513bc12a68d77253b20d94f261b117bbf897 (patch) | |
| tree | 3d914c5f38b745ab34b639aa80832428f3d74aaf /chrome/common/env_vars.cc | |
| parent | 4ed69832c6178bfd8f07a77035ea0a9223276695 (diff) | |
| download | chromium_src-6bd1513bc12a68d77253b20d94f261b117bbf897.zip chromium_src-6bd1513bc12a68d77253b20d94f261b117bbf897.tar.gz chromium_src-6bd1513bc12a68d77253b20d94f261b117bbf897.tar.bz2 | |
Windows Breakpad: Remove kNoOOBreakpad environment variable
The env var kNoOOBreakpad (NO_OO_BREAKPAD) was used as a global
variable to communicate in-process between chrome.exe and chrome.dll
so that the latter can report via UMA whether Breakpad was enabled
(with the counts kStabilityBreakpadRegistrationFail and
kStabilityBreakpadRegistrationSuccess, also known as
"user_experience_metrics.stability.breakpad_registration_ok" and
"user_experience_metrics.stability.breakpad_registration_fail".)
But this was broken:
* In the browser process, checking for Breakpad enablement happens in
a thread, so the UMA report might happen before Breakpad is
enabled, in which case the UMA report would be wrong.
* If Breakpad is not enabled, kNoOOBreakpad would not be set, and
chrome_browser_main_win.cc would assume this meant that Breakpad
was enabled successfully.
If the stat is wrong and no-one noticed, we might as well remove it
and simplify the code.
BUG=111265
TEST=none
Review URL: http://codereview.chromium.org/9391030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121955 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/env_vars.cc')
| -rwxr-xr-x[-rw-r--r--] | chrome/common/env_vars.cc | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/chrome/common/env_vars.cc b/chrome/common/env_vars.cc index f63d3e4..f75da13 100644..100755 --- a/chrome/common/env_vars.cc +++ b/chrome/common/env_vars.cc @@ -1,4 +1,4 @@ -// Copyright (c) 2010 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -33,10 +33,6 @@ const char kRestartInfo[] = "CHROME_RESTART"; const char kRtlLocale[] = "RIGHT_TO_LEFT"; const char kLtrLocale[] = "LEFT_TO_RIGHT"; -// If the out-of-process breakpad could not be installed, we set this variable -// according to the process. -const char kNoOOBreakpad[] = "NO_OO_BREAKPAD"; - // Number of times to run a given startup_tests unit test. const char kStartupTestsNumCycles[] = "STARTUP_TESTS_NUMCYCLES"; |