diff options
| author | jamescook <jamescook@chromium.org> | 2014-09-16 10:02:08 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-09-16 17:03:09 +0000 |
| commit | bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a (patch) | |
| tree | 4efb6754a787762a7a8677af63dd21fee160e36d /chrome/common/extensions/api/file_browser_handlers | |
| parent | d575eafb4f112ed0c0f4be8cf58dfb8f71d4a142 (diff) | |
| download | chromium_src-bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a.zip chromium_src-bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a.tar.gz chromium_src-bd1cc624f6fd9761409ee8a8ac5cfd3a5896c87a.tar.bz2 | |
Refactor ExtensionManifestTest to allow usage in src/extensions
This refactor will allow some manifest tests running in Chrome's unit_tests
suite to move to the extensions_unittests suite.
* Rename ExtensionManifestTest to extensions::ManifestTest and move it into
src/extensions.
* Introduce ChromeManifestTest to load manifests from Chrome's test data dir.
* Eliminate some unnecessary use of chrome::VersionInfo::Channel.
* Move SharedModuleManifestTest to extensions_unittests as an example.
FileHandlerManifestTest and ExternallyConnectableManifestTest will be next,
but require more refactoring (e.g. of permissions).
BUG=397165
TEST=unit_tests, extensions_unittests
Review URL: https://codereview.chromium.org/572813002
Cr-Commit-Position: refs/heads/master@{#295087}
Diffstat (limited to 'chrome/common/extensions/api/file_browser_handlers')
| -rw-r--r-- | chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc index 16e669e..d829eaf 100644 --- a/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc +++ b/chrome/common/extensions/api/file_browser_handlers/file_browser_handler_manifest_unittest.cc @@ -5,7 +5,7 @@ #include "base/strings/string_number_conversions.h" #include "chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h" #include "chrome/common/extensions/extension_constants.h" -#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" +#include "chrome/common/extensions/manifest_tests/chrome_manifest_test.h" #include "extensions/common/error_utils.h" #include "extensions/common/extension_builder.h" #include "extensions/common/manifest_constants.h" @@ -21,7 +21,7 @@ using extensions::ListBuilder; namespace { -class FileBrowserHandlerManifestTest : public ExtensionManifestTest { +class FileBrowserHandlerManifestTest : public ChromeManifestTest { }; TEST_F(FileBrowserHandlerManifestTest, InvalidFileBrowserHandlers) { |