summaryrefslogtreecommitdiffstats
path: root/chrome/common/extensions/extension_file_util_unittest.cc
diff options
context:
space:
mode:
authorthestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-14 07:32:45 +0000
committerthestig@chromium.org <thestig@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>2013-02-14 07:32:45 +0000
commitc9c89a156b8769fab8b25f64343ae2bc89706750 (patch)
treef248914e905950fb60118e38065004cdeb144fd2 /chrome/common/extensions/extension_file_util_unittest.cc
parent2f95bf6f3832adcc2c9cf330ad837f30e76884c4 (diff)
downloadchromium_src-c9c89a156b8769fab8b25f64343ae2bc89706750.zip
chromium_src-c9c89a156b8769fab8b25f64343ae2bc89706750.tar.gz
chromium_src-c9c89a156b8769fab8b25f64343ae2bc89706750.tar.bz2
Cleanup: Remove deprecated base::Value methods from chrome/common. Use base::Value too.
Review URL: https://chromiumcodereview.appspot.com/12207167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182406 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/extensions/extension_file_util_unittest.cc')
-rw-r--r--chrome/common/extensions/extension_file_util_unittest.cc25
1 files changed, 13 insertions, 12 deletions
diff --git a/chrome/common/extensions/extension_file_util_unittest.cc b/chrome/common/extensions/extension_file_util_unittest.cc
index 25ed860..dc3fd3b 100644
--- a/chrome/common/extensions/extension_file_util_unittest.cc
+++ b/chrome/common/extensions/extension_file_util_unittest.cc
@@ -379,7 +379,7 @@ TEST_F(ExtensionFileUtilTest, ExtensionResourceURLToFilePath) {
}
static scoped_refptr<Extension> LoadExtensionManifest(
- DictionaryValue* manifest,
+ base::DictionaryValue* manifest,
const base::FilePath& manifest_dir,
Manifest::Location location,
int extra_flags,
@@ -396,15 +396,16 @@ static scoped_refptr<Extension> LoadExtensionManifest(
int extra_flags,
std::string* error) {
JSONStringValueSerializer serializer(manifest_value);
- scoped_ptr<Value> result(serializer.Deserialize(NULL, error));
+ scoped_ptr<base::Value> result(serializer.Deserialize(NULL, error));
if (!result.get())
return NULL;
- CHECK_EQ(Value::TYPE_DICTIONARY, result->GetType());
- return LoadExtensionManifest(static_cast<DictionaryValue*>(result.get()),
- manifest_dir,
- location,
- extra_flags,
- error);
+ CHECK_EQ(base::Value::TYPE_DICTIONARY, result->GetType());
+ return LoadExtensionManifest(
+ static_cast<base::DictionaryValue*>(result.get()),
+ manifest_dir,
+ location,
+ extra_flags,
+ error);
}
#if defined(OS_WIN)
@@ -448,13 +449,13 @@ TEST_F(ExtensionFileUtilTest, MAYBE_BackgroundScriptsMustExist) {
base::ScopedTempDir temp;
ASSERT_TRUE(temp.CreateUniqueTempDir());
- scoped_ptr<DictionaryValue> value(new DictionaryValue());
+ scoped_ptr<base::DictionaryValue> value(new base::DictionaryValue());
value->SetString("name", "test");
value->SetString("version", "1");
value->SetInteger("manifest_version", 1);
- ListValue* scripts = new ListValue();
- scripts->Append(Value::CreateStringValue("foo.js"));
+ base::ListValue* scripts = new base::ListValue();
+ scripts->Append(new base::StringValue("foo.js"));
value->Set("background.scripts", scripts);
std::string error;
@@ -471,7 +472,7 @@ TEST_F(ExtensionFileUtilTest, MAYBE_BackgroundScriptsMustExist) {
EXPECT_EQ(0U, warnings.size());
scripts->Clear();
- scripts->Append(Value::CreateStringValue("http://google.com/foo.js"));
+ scripts->Append(new base::StringValue("http://google.com/foo.js"));
extension = LoadExtensionManifest(value.get(), temp.path(), Manifest::LOAD,
0, &error);