Rewrite std::string("") to std::string(), Linux edition.

This patch was generated by running the empty_string clang tool
across the Chromium Linux compilation database. Implicitly or
explicitly constructing std::string() with a "" argument is
inefficient as the caller needs to emit extra instructions to
pass an argument, and the constructor needlessly copies a byte
into internal storage. Rewriting these instances to simply call
the default constructor appears to save ~14-18 kilobytes on an
optimized release build.

BUG=none

Review URL: https://codereview.chromium.org/13145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193020 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 12 insertions, 7 deletions

diff --git a/chrome/common/extensions/extension_localization_peer_unittest.cc b/chrome/common/extensions/extension_localization_peer_unittest.cc
index 92085ed..df74791 100644
--- a/chrome/common/extensions/extension_localization_peer_unittest.cc
+++ b/chrome/common/extensions/extension_localization_peer_unittest.cc
@@ -144,8 +144,8 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestBadURLRequestStatus) {
   EXPECT_CALL(*original_peer_, OnCompletedRequest(
     net::ERR_ABORTED, false, "", base::TimeTicks()));
 
-  filter_peer->OnCompletedRequest(net::ERR_FAILED, false, "",
-                                  base::TimeTicks());
+  filter_peer->OnCompletedRequest(
+      net::ERR_FAILED, false, std::string(), base::TimeTicks());
 }
 
 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) {
@@ -159,7 +159,8 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) {
   EXPECT_CALL(*original_peer_, OnCompletedRequest(
       net::OK, false, "", base::TimeTicks()));
 
-  filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+  filter_peer->OnCompletedRequest(
+      net::OK, false, std::string(), base::TimeTicks());
 }
 
 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) {
@@ -178,14 +179,16 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) {
   EXPECT_CALL(*original_peer_, OnCompletedRequest(
           net::OK, false, "", base::TimeTicks())).Times(2);
 
-  filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+  filter_peer->OnCompletedRequest(
+      net::OK, false, std::string(), base::TimeTicks());
 
   // Test if Send gets called again (it shouldn't be) when first call returned
   // an empty dictionary.
   filter_peer =
       CreateExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
   SetData(filter_peer, "some text");
-  filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+  filter_peer->OnCompletedRequest(
+      net::OK, false, std::string(), base::TimeTicks());
 }
 
 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) {
@@ -213,7 +216,8 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) {
   EXPECT_CALL(*original_peer_, OnCompletedRequest(
       net::OK, false, "", base::TimeTicks()));
 
-  filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+  filter_peer->OnCompletedRequest(
+      net::OK, false, std::string(), base::TimeTicks());
 }
 
 TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) {
@@ -241,5 +245,6 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) {
   EXPECT_CALL(*original_peer_, OnCompletedRequest(
       net::OK, false, "", base::TimeTicks()));
 
-  filter_peer->OnCompletedRequest(net::OK, false, "", base::TimeTicks());
+  filter_peer->OnCompletedRequest(
+      net::OK, false, std::string(), base::TimeTicks());
 }