diff options
| author | grunell@google.com <grunell@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-15 20:03:58 +0000 |
|---|---|---|
| committer | grunell@google.com <grunell@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-15 20:03:58 +0000 |
| commit | dd0136f38d116c9f62f5f23ecb9c5f3c1c91e28b (patch) | |
| tree | 7656d74a75fd413de2b88b89c6342d07ee47a21a /chrome/common/media | |
| parent | dfa8e9797f4341fd148be8f79b429646c264e4e3 (diff) | |
| download | chromium_src-dd0136f38d116c9f62f5f23ecb9c5f3c1c91e28b.zip chromium_src-dd0136f38d116c9f62f5f23ecb9c5f3c1c91e28b.tar.gz chromium_src-dd0136f38d116c9f62f5f23ecb9c5f3c1c91e28b.tar.bz2 | |
Changed WebRTC logging to send log messages from renderer to browser side and write them to the buffer there.
Buffering is done on the renderer side so that IPC isn't overloaded.
As a side note, the design will be revisited soon; issue 333894.
BUG=332957
R=cdn@chromium.org, jochen@chromium.org, joi@chromium.org, vrk@chromium.org
Review URL: https://codereview.chromium.org/135403004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@244965 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/media')
| -rw-r--r-- | chrome/common/media/webrtc_logging_messages.h | 17 |
1 files changed, 11 insertions, 6 deletions
diff --git a/chrome/common/media/webrtc_logging_messages.h b/chrome/common/media/webrtc_logging_messages.h index af2ada3..e28cca3 100644 --- a/chrome/common/media/webrtc_logging_messages.h +++ b/chrome/common/media/webrtc_logging_messages.h @@ -5,6 +5,8 @@ // IPC messages for WebRTC logging. // Multiply-included message file, hence no include guard. +#include <string> + #include "base/memory/shared_memory.h" #include "ipc/ipc_message_macros.h" @@ -12,15 +14,18 @@ // Messages sent from the renderer to the browser. -// Notification that the log has been closed. +// Send log message to add to log. +IPC_MESSAGE_CONTROL1(WebRtcLoggingMsg_AddLogMessage, + std::string /* message */) + +// Notification that the renderer has stopped sending log messages to the +// browser. IPC_MESSAGE_CONTROL0(WebRtcLoggingMsg_LoggingStopped) // Messages sent from the browser to the renderer. -// Tells the renderer to open the log. -IPC_MESSAGE_CONTROL2(WebRtcLoggingMsg_StartLogging, - base::SharedMemoryHandle /* handle */, - uint32 /* length */) +// Tells the renderer to start sending log messages to the browser. +IPC_MESSAGE_CONTROL0(WebRtcLoggingMsg_StartLogging) -// Tells the renderer to close the log. +// Tells the renderer to stop sending log messages to the browser. IPC_MESSAGE_CONTROL0(WebRtcLoggingMsg_StopLogging) |