diff options
| author | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-04 16:46:48 +0000 |
|---|---|---|
| committer | mseaborn@chromium.org <mseaborn@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-04 16:46:48 +0000 |
| commit | fd37bf65c63bced08f6ca7e70a8aad5e2ba6bbbb (patch) | |
| tree | 638dc2ece5a78774910f1499b5e4faba7dff67b6 /chrome/common/nacl_messages.h | |
| parent | 894a34f3e5298a2a73cc4ff0bc5360900596fb5a (diff) | |
| download | chromium_src-fd37bf65c63bced08f6ca7e70a8aad5e2ba6bbbb.zip chromium_src-fd37bf65c63bced08f6ca7e70a8aad5e2ba6bbbb.tar.gz chromium_src-fd37bf65c63bced08f6ca7e70a8aad5e2ba6bbbb.tar.bz2 | |
NaCl: Pass process info through to the Windows debug exception handler
This removes the assumption that NaCl's data structures are located at
the same addresses in the debugger and debuggee processes, because we
pass the addresses of the data structures through IPC instead.
This fixes the debug exception handler to work in cases where
chrome.dll or nacl64.exe get relocated, which tends to happen for
chrome.dll on Windows XP. (However, since there are no trybots for
32-bit Windows, I will enable the test on 32-bit Windows in a separate
change.)
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2695
TEST=run_inbrowser_exception_test in nacl_integration
Review URL: https://chromiumcodereview.appspot.com/10351016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135361 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/nacl_messages.h')
| -rw-r--r-- | chrome/common/nacl_messages.h | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/chrome/common/nacl_messages.h b/chrome/common/nacl_messages.h index 12243de..8200d65 100644 --- a/chrome/common/nacl_messages.h +++ b/chrome/common/nacl_messages.h @@ -37,9 +37,10 @@ IPC_MESSAGE_CONTROL2(NaClProcessMsg_LoaderLaunched, // Tells the NaCl broker to attach a debug exception handler to the // given NaCl loader process. -IPC_MESSAGE_CONTROL2(NaClProcessMsg_LaunchDebugExceptionHandler, +IPC_MESSAGE_CONTROL3(NaClProcessMsg_LaunchDebugExceptionHandler, int32 /* pid of the NaCl process */, - base::ProcessHandle /* handle of the NaCl process */) + base::ProcessHandle /* handle of the NaCl process */, + std::string /* NaCl internal process layout info */) // Notify the browser process that the broker process finished // attaching a debug exception handler to the given NaCl loader |