diff options
| author | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-27 20:45:59 +0000 |
|---|---|---|
| committer | jam@chromium.org <jam@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-03-27 20:45:59 +0000 |
| commit | 51d70e07bd5d991420bc0f14ff05f1a9b72d02db (patch) | |
| tree | 718c0b24680c1b14eb4570403cc15b8d09b4002d /chrome/common/plugin_messages_internal.h | |
| parent | 70ac249f04337f0040ad63a72ced111d87fdc73a (diff) | |
| download | chromium_src-51d70e07bd5d991420bc0f14ff05f1a9b72d02db.zip chromium_src-51d70e07bd5d991420bc0f14ff05f1a9b72d02db.tar.gz chromium_src-51d70e07bd5d991420bc0f14ff05f1a9b72d02db.tar.bz2 | |
Refactor plugin process code which checks with the browser process before shutdown, to avoid races in which the browser process thinks the process is fine to use while it's shutting down. I also removed PluginProcess/WorkerProcess since they didn't have any code in them now.
I removed the plugin process code which waits 10 seconds before shutting itself down. That was a premature optimization, since testing with/without this didn't show any difference (see http://www/~jabdelmalek/chrome/test/plugins/processes.html). In both cases, the plugin on a page would get recreated in less than 100ms, even with reusing or starting a plugin process from scratch. We already spawn new renderer processes on back and forth if it's a different origin, and the plugin will be in the cache anyways.
Review URL: http://codereview.chromium.org/53091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12703 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/plugin_messages_internal.h')
| -rw-r--r-- | chrome/common/plugin_messages_internal.h | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/chrome/common/plugin_messages_internal.h b/chrome/common/plugin_messages_internal.h index b9c7a58..61c53f0 100644 --- a/chrome/common/plugin_messages_internal.h +++ b/chrome/common/plugin_messages_internal.h @@ -16,15 +16,19 @@ IPC_BEGIN_MESSAGES(PluginProcess) IPC_MESSAGE_CONTROL1(PluginProcessMsg_CreateChannel, bool /* off_the_record */) - IPC_MESSAGE_CONTROL1(PluginProcessMsg_ShutdownResponse, - bool /* ok to shutdown */) - // Allows a chrome plugin loaded in the browser process to send arbitrary // data to an instance of the same plugin loaded in a plugin process. IPC_MESSAGE_CONTROL1(PluginProcessMsg_PluginMessage, std::vector<uint8> /* opaque data */) - IPC_MESSAGE_CONTROL0(PluginProcessMsg_BrowserShutdown) + // The following messages are used by all child processes, even though they + // are listed under PluginProcess. It seems overkill to define ChildProcess. + // Tells the child process it should stop. + IPC_MESSAGE_CONTROL0(PluginProcessMsg_AskBeforeShutdown) + + // Sent in response to PluginProcessHostMsg_ShutdownRequest to tell the child + // process that it's safe to shutdown. + IPC_MESSAGE_CONTROL0(PluginProcessMsg_Shutdown) IPC_END_MESSAGES(PluginProcess) |