diff options
| author | stuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-04 17:27:08 +0000 |
|---|---|---|
| committer | stuartmorgan@chromium.org <stuartmorgan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2009-11-04 17:27:08 +0000 |
| commit | a96ec6a0045c0b1926c9e4c553b67e42a43a430b (patch) | |
| tree | 017387bccd62964c28a0892b78614a0f1820282e /chrome/common/plugin_messages_internal.h | |
| parent | 39a2e833dc1983b78e9cf78df3d8f3cda3f150c9 (diff) | |
| download | chromium_src-a96ec6a0045c0b1926c9e4c553b67e42a43a430b.zip chromium_src-a96ec6a0045c0b1926c9e4c553b67e42a43a430b.tar.gz chromium_src-a96ec6a0045c0b1926c9e4c553b67e42a43a430b.tar.bz2 | |
Don't allow the browser to stay above a modal plugin window (Mac)
There's a flicker of the modal window being hidden then coming forward again, and the menus still work, so we'll most likely have fake the modality more aggressively at some point. This gets us the basic infrastructure though, and solves the severe usability problem.
BUG=20798
TEST=Open a modal plugin window (e.g., Gmail upload). Switch to another app, then back to Chrome; the plugin window should come to the front.
Review URL: http://codereview.chromium.org/355021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30965 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/plugin_messages_internal.h')
| -rw-r--r-- | chrome/common/plugin_messages_internal.h | 10 |
1 files changed, 6 insertions, 4 deletions
diff --git a/chrome/common/plugin_messages_internal.h b/chrome/common/plugin_messages_internal.h index cd44d21..f9a5bbf 100644 --- a/chrome/common/plugin_messages_internal.h +++ b/chrome/common/plugin_messages_internal.h @@ -131,14 +131,16 @@ IPC_BEGIN_MESSAGES(PluginProcessHost) // Notifies the browser that the plugin has selected a window (i.e., brought // it to the front and wants it to have keyboard focus). - IPC_MESSAGE_CONTROL2(PluginProcessHostMsg_PluginSelectWindow, + IPC_MESSAGE_CONTROL3(PluginProcessHostMsg_PluginSelectWindow, uint32 /* window ID */, - gfx::Rect /* window rect */) + gfx::Rect /* window rect */, + bool /* modal */) // Notifies the browser that the plugin has shown a window. - IPC_MESSAGE_CONTROL2(PluginProcessHostMsg_PluginShowWindow, + IPC_MESSAGE_CONTROL3(PluginProcessHostMsg_PluginShowWindow, uint32 /* window ID */, - gfx::Rect /* window rect */) + gfx::Rect /* window rect */, + bool /* modal */) // Notifies the browser that the plugin has hidden a window. IPC_MESSAGE_CONTROL2(PluginProcessHostMsg_PluginHideWindow, |