The ResourceDispatcher object does not honor the deferred load flag for a request correctly. If this flag is set it correctly queues up any subsequent responses.

When the flag is reset it starts dispatching these responses. If the deferred flag is set in the context
of these responses it continues to dispatch further responses, which is not correct.

Fix is to check if the deferred flag for a request is set in the context of a response and stop dispatching if yes.

This fixes bug http://code.google.com/p/chromium/issues/detail?id=19931 and could potentially explain 
this http://code.google.com/p/chromium/issues/detail?id=19393

Bug=19931
Test= Covered by unit test.
 

Review URL: http://codereview.chromium.org/173187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24069 0039d316-1c4b-4281-b951-d872f2087c98

1 files changed, 6 insertions, 0 deletions

diff --git a/chrome/common/resource_dispatcher.cc b/chrome/common/resource_dispatcher.cc
index d0a90a5..d951a33 100644
--- a/chrome/common/resource_dispatcher.cc
+++ b/chrome/common/resource_dispatcher.cc
@@ -528,6 +528,12 @@ void ResourceDispatcher::FlushDeferredMessages(int request_id) {
     q.pop_front();
     DispatchMessage(*m);
     delete m;
+    // If this request is deferred in the context of the above message, then we
+    // should honor the same and stop dispatching further messages.
+    if (request_info.is_deferred) {
+      request_info.deferred_message_queue.swap(q);
+      return;
+    }
   }
 }