diff options
| author | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-12 22:26:24 +0000 |
|---|---|---|
| committer | groby@chromium.org <groby@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-04-12 22:26:24 +0000 |
| commit | cea54ee919ff03ebbc5c2a88881e4f1cc6edc235 (patch) | |
| tree | e57268de20fb0b7261214fe72c914295a045abd1 /chrome/common/spellcheck_messages.h | |
| parent | e9d2ba6f66503b29f50fae511b57500a3d782ae1 (diff) | |
| download | chromium_src-cea54ee919ff03ebbc5c2a88881e4f1cc6edc235.zip chromium_src-cea54ee919ff03ebbc5c2a88881e4f1cc6edc235.tar.gz chromium_src-cea54ee919ff03ebbc5c2a88881e4f1cc6edc235.tar.bz2 | |
[Spellcheck] Remove dead IPC message
The DocumentClosed message could never be sent, since the IPC::Sender
is already gone by the time we know we need to send this.
In detail: SpellcheckProvider is a RenderViewObserver. When a
RenderView goes away, it goes through these steps:
1) Call RenderViewObserver::RenderViewGone()
This sets RenderViewObserver::render_view_ to NULL
2) Call RenderViewObserver::OnDestruct();
3) delete RenderViewObserver()
render_view_ is needed to send an IPC message, but RenderViewGone is
not overrideable. That means we cannot send a notification to the
browser that a RenderView has left the building.
TBR=tsepez@chromium.org
R=rlp@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/13966004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194028 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common/spellcheck_messages.h')
| -rw-r--r-- | chrome/common/spellcheck_messages.h | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/chrome/common/spellcheck_messages.h b/chrome/common/spellcheck_messages.h index 171d30f..c201311 100644 --- a/chrome/common/spellcheck_messages.h +++ b/chrome/common/spellcheck_messages.h @@ -95,11 +95,6 @@ IPC_MESSAGE_CONTROL3(SpellCheckHostMsg_CallSpellingService, #endif #if defined(OS_MACOSX) -// This message tells the spellchecker that a document has been closed and all -// of the ignored words for that document can be forgotten. -IPC_MESSAGE_ROUTED1(SpellCheckHostMsg_DocumentClosed, - int /* route_id to identify document */) - // Tells the browser to display or not display the SpellingPanel IPC_MESSAGE_ROUTED1(SpellCheckHostMsg_ShowSpellingPanel, bool /* if true, then show it, otherwise hide it*/) |