diff options
| author | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-25 00:29:32 +0000 |
|---|---|---|
| committer | rlarocque@chromium.org <rlarocque@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2013-06-25 00:29:32 +0000 |
| commit | 389f566a8d88ba4849dc1c2179e00bf64b1d1b39 (patch) | |
| tree | ad64c2dbf6b004f43fe3e8a0e7bd539f223a51f4 /chrome/common | |
| parent | ccdcf4375d9a79dcea5d92692db30ae199ffff28 (diff) | |
| download | chromium_src-389f566a8d88ba4849dc1c2179e00bf64b1d1b39.zip chromium_src-389f566a8d88ba4849dc1c2179e00bf64b1d1b39.tar.gz chromium_src-389f566a8d88ba4849dc1c2179e00bf64b1d1b39.tar.bz2 | |
Make use of InvalidationService
The InvalidationService was introduced r199520. That commit added the
InvalidationService interface and several implementations of it, but
made no use of the new code. This commit builds on that work.
Up until now, TICL invalidations were handled on the sync thread. The
related objects were instantiated and owned by the SyncBackendHost and
SyncManager. All requests to update the set of object registrations had
to be passed to the sync thread. Components that wanted to receive
invalidations but were not part of sync had to route their communication
with the invalidations server through ProfileSyncService to get to the
sync thread. Things were a bit different on Android, but the system
still tried to pretend that invalidations were owned by the sync thread.
The new InvalidationService implementation is a ProfileKeyedService that
is mostly independent from sync. It still relies on sync to manage sign
in and fetch the appropriate auth tokens. However, it's now much easier
for components outside of sync to communication with the invalidations
server.
The new system allows us to remove a lot of invalidations-related code
from the ProfileSyncService, SyncBackendHost and SyncManager. Sync is
now just one of many clients of the InvalidationService. The
SyncBackendHost is responsible for forwarding messages back and forth
between the InvalidationService and the sync thread.
TBR=sky,erg
BUG=124137
Review URL: https://chromiumcodereview.appspot.com/15580002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208315 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/chrome_switches.cc | 3 | ||||
| -rw-r--r-- | chrome/common/chrome_switches.h | 1 |
2 files changed, 0 insertions, 4 deletions
diff --git a/chrome/common/chrome_switches.cc b/chrome/common/chrome_switches.cc index 72825e9c..9df9cbe 100644 --- a/chrome/common/chrome_switches.cc +++ b/chrome/common/chrome_switches.cc @@ -1347,9 +1347,6 @@ const char kSyncKeystoreEncryption[] = "sync-keystore-encryption"; const char kSyncShortInitialRetryOverride[] = "sync-short-initial-retry-override"; -// Overrides the default notification method for sync. -const char kSyncNotificationMethod[] = "sync-notification-method"; - // Overrides the default host:port used for sync notifications. const char kSyncNotificationHostPort[] = "sync-notification-host-port"; diff --git a/chrome/common/chrome_switches.h b/chrome/common/chrome_switches.h index ce4b2f8..51351a9 100644 --- a/chrome/common/chrome_switches.h +++ b/chrome/common/chrome_switches.h @@ -356,7 +356,6 @@ extern const char kSyncAllowInsecureXmppConnection[]; extern const char kSyncInvalidateXmppLogin[]; extern const char kSyncKeystoreEncryption[]; extern const char kSyncShortInitialRetryOverride[]; -extern const char kSyncNotificationMethod[]; extern const char kSyncNotificationHostPort[]; extern const char kSyncServiceURL[]; extern const char kSyncTabFavicons[]; |