diff options
author | rdevlin.cronin <rdevlin.cronin@chromium.org> | 2016-03-24 17:10:47 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2016-03-25 00:12:11 +0000 |
commit | 467b5a8a1ccb999cbbd04a86bdec9a893e960a2c (patch) | |
tree | a909ae7fa06ce933943b3fad5a8b7eede8a3764d /chrome/common | |
parent | b4f0ff0df44c8bc5eb25b1518cae1d1b24add741 (diff) | |
download | chromium_src-467b5a8a1ccb999cbbd04a86bdec9a893e960a2c.zip chromium_src-467b5a8a1ccb999cbbd04a86bdec9a893e960a2c.tar.gz chromium_src-467b5a8a1ccb999cbbd04a86bdec9a893e960a2c.tar.bz2 |
[Extensions] Convert APIs to use movable types [5]
Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- file_browser_handler.json
- file_browser_handler_internal.json
- file_manager_private.idl
- file_manager_private_internal.idl
- file_system.idl
- file_system_provider.idl
- file_system_provider_internal.idl
BUG=595949
Review URL: https://codereview.chromium.org/1829783002
Cr-Commit-Position: refs/heads/master@{#383198}
Diffstat (limited to 'chrome/common')
7 files changed, 13 insertions, 6 deletions
diff --git a/chrome/common/extensions/api/file_browser_handler.json b/chrome/common/extensions/api/file_browser_handler.json index 0012ac7..9c63cf5 100644 --- a/chrome/common/extensions/api/file_browser_handler.json +++ b/chrome/common/extensions/api/file_browser_handler.json @@ -6,6 +6,7 @@ { "namespace":"fileBrowserHandler", "description": "Use the <code>chrome.fileBrowserHandler</code> API to extend the Chrome OS file browser. For example, you can use this API to enable users to upload files to your website.", + "compiler_options": {"use_movable_types": true}, "types": [ { "id": "FileHandlerExecuteEventDetails", diff --git a/chrome/common/extensions/api/file_browser_handler_internal.json b/chrome/common/extensions/api/file_browser_handler_internal.json index b3023e4..68a3314 100644 --- a/chrome/common/extensions/api/file_browser_handler_internal.json +++ b/chrome/common/extensions/api/file_browser_handler_internal.json @@ -6,7 +6,8 @@ { "namespace": "fileBrowserHandlerInternal", "compiler_options": { - "implemented_in": "chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.h" + "implemented_in": "chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.h", + "use_movable_types": true }, "description": "none", "types": [ diff --git a/chrome/common/extensions/api/file_manager_private.idl b/chrome/common/extensions/api/file_manager_private.idl index 1f92486..8313ea9 100644 --- a/chrome/common/extensions/api/file_manager_private.idl +++ b/chrome/common/extensions/api/file_manager_private.idl @@ -5,7 +5,8 @@ // fileManagerPrivate API. // This is a private API used by the file browser of ChromeOS. [platforms=("chromeos"), - implemented_in="chrome/browser/chromeos/extensions/file_manager/file_manager_private_api_functions.h"] + implemented_in="chrome/browser/chromeos/extensions/file_manager/file_manager_private_api_functions.h", + use_movable_types=true] namespace fileManagerPrivate { // Type of the mounted volume. enum VolumeType { drive, downloads, removable, archive, provided, mtp, diff --git a/chrome/common/extensions/api/file_manager_private_internal.idl b/chrome/common/extensions/api/file_manager_private_internal.idl index 39739f2..404a19d 100644 --- a/chrome/common/extensions/api/file_manager_private_internal.idl +++ b/chrome/common/extensions/api/file_manager_private_internal.idl @@ -4,7 +4,8 @@ // Internal, used by fileManagerPrivate's custom bindings. [platforms=("chromeos"), - implemented_in="chrome/browser/chromeos/extensions/file_manager/file_manager_private_api_functions.h"] + implemented_in="chrome/browser/chromeos/extensions/file_manager/file_manager_private_api_functions.h", + use_movable_types=true] namespace fileManagerPrivateInternal { // Entry information that renderers need to create an Entry instance. dictionary EntryDescription { diff --git a/chrome/common/extensions/api/file_system.idl b/chrome/common/extensions/api/file_system.idl index 6ea554a..0df621c 100644 --- a/chrome/common/extensions/api/file_system.idl +++ b/chrome/common/extensions/api/file_system.idl @@ -7,7 +7,7 @@ // read and write to a user-selected location. For example, a text editor app // can use the API to read and write local documents. All failures are notified // via chrome.runtime.lastError. -namespace fileSystem { +[use_movable_types=true] namespace fileSystem { dictionary AcceptOption { // This is the optional text description for this option. If not present, // a description will be automatically generated; typically containing an diff --git a/chrome/common/extensions/api/file_system_provider.idl b/chrome/common/extensions/api/file_system_provider.idl index b18d46a..38882b1 100644 --- a/chrome/common/extensions/api/file_system_provider.idl +++ b/chrome/common/extensions/api/file_system_provider.idl @@ -4,7 +4,8 @@ // Use the <code>chrome.fileSystemProvider</code> API to create file systems, // that can be accessible from the file manager on Chrome OS. -[implemented_in="chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h"] +[implemented_in="chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h", + use_movable_types=true] namespace fileSystemProvider { // Error codes used by providing extensions in response to requests as well // as in case of errors when calling methods of the API. For success, diff --git a/chrome/common/extensions/api/file_system_provider_internal.idl b/chrome/common/extensions/api/file_system_provider_internal.idl index af3db41..449e37c 100644 --- a/chrome/common/extensions/api/file_system_provider_internal.idl +++ b/chrome/common/extensions/api/file_system_provider_internal.idl @@ -4,7 +4,9 @@ // Internal, used by fileSystemProvider's custom bindings. These functions are // called when events' callbacks are invoked. -[implemented_in="chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h", nodoc] +[implemented_in="chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.h", + nodoc, + use_movable_types=true] namespace fileSystemProviderInternal { interface Functions { // Internal. Success callback of the <code>onUnmountRequested</code> |