diff options
| author | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-10 01:56:15 +0000 |
|---|---|---|
| committer | cmp@chromium.org <cmp@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2011-11-10 01:56:15 +0000 |
| commit | 5ccd4951d9e4c598395ec9135ff5569d42d5c41a (patch) | |
| tree | 2ec430c8ddea109359024f5b53f331ce7aa1cb9f /chrome/common | |
| parent | 91d00b738e9e99c25e3e901426214e34a40e3007 (diff) | |
| download | chromium_src-5ccd4951d9e4c598395ec9135ff5569d42d5c41a.zip chromium_src-5ccd4951d9e4c598395ec9135ff5569d42d5c41a.tar.gz chromium_src-5ccd4951d9e4c598395ec9135ff5569d42d5c41a.tar.bz2 | |
Revert 109213 - Take script URLs into account when applying script content settings.
<cmp> We suspect this CL caused a performance regression on chromium.perf.
Reverting to see if this is the source of the regression.
Transmit script content settings to the renderer. Use the script URL as the secondary URL
for the content setting rules.
BUG=90840
TEST=ChromeRenderViewTest.ContentSettings(Allow|Block)Scripts
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109005
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109036
Review URL: http://codereview.chromium.org/8409006
TBR=marja@chromium.org
Review URL: http://codereview.chromium.org/8510040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109362 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/content_settings.cc | 4 | ||||
| -rw-r--r-- | chrome/common/content_settings.h | 7 | ||||
| -rw-r--r-- | chrome/common/render_messages.h | 11 |
3 files changed, 3 insertions, 19 deletions
diff --git a/chrome/common/content_settings.cc b/chrome/common/content_settings.cc index cd30d6c..ecf26f8 100644 --- a/chrome/common/content_settings.cc +++ b/chrome/common/content_settings.cc @@ -33,7 +33,3 @@ ContentSettingPatternSource::ContentSettingPatternSource( incognito(incognito) {} ContentSettingPatternSource::ContentSettingPatternSource() {} - -RendererContentSettingRules::RendererContentSettingRules() {} - -RendererContentSettingRules::~RendererContentSettingRules() {} diff --git a/chrome/common/content_settings.h b/chrome/common/content_settings.h index cff4102..ec500b6 100644 --- a/chrome/common/content_settings.h +++ b/chrome/common/content_settings.h @@ -76,11 +76,4 @@ struct SettingInfo { } // namespace content_settings -struct RendererContentSettingRules { - RendererContentSettingRules(); - ~RendererContentSettingRules(); - ContentSettingsForOneType image_rules; - ContentSettingsForOneType script_rules; -}; - #endif // CHROME_COMMON_CONTENT_SETTINGS_H_ diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h index 89e395e..1d7b41d 100644 --- a/chrome/common/render_messages.h +++ b/chrome/common/render_messages.h @@ -148,11 +148,6 @@ IPC_STRUCT_TRAITS_BEGIN(ContentSettingPatternSource) IPC_STRUCT_TRAITS_MEMBER(incognito) IPC_STRUCT_TRAITS_END() -IPC_STRUCT_TRAITS_BEGIN(RendererContentSettingRules) - IPC_STRUCT_TRAITS_MEMBER(image_rules) - IPC_STRUCT_TRAITS_MEMBER(script_rules) -IPC_STRUCT_TRAITS_END() - IPC_STRUCT_TRAITS_BEGIN(ThumbnailScore) IPC_STRUCT_TRAITS_MEMBER(boring_score) IPC_STRUCT_TRAITS_MEMBER(good_clipping) @@ -250,9 +245,9 @@ IPC_MESSAGE_CONTROL2(ChromeViewMsg_SetContentSettingsForCurrentURL, IPC_MESSAGE_CONTROL1(ChromeViewMsg_SetDefaultContentSettings, ContentSettings /* content_settings */) -// Set the content setting rules stored by the renderer. -IPC_MESSAGE_CONTROL1(ChromeViewMsg_SetContentSettingRules, - RendererContentSettingRules /* rules */) +// Set the content settings for images. +IPC_MESSAGE_CONTROL1(ChromeViewMsg_SetImageSettingRules, + ContentSettingsForOneType /* rules */) // Tells the render view to load all blocked plugins. IPC_MESSAGE_ROUTED0(ChromeViewMsg_LoadBlockedPlugins) |