diff options
author | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-14 05:31:51 +0000 |
---|---|---|
committer | sreeram@chromium.org <sreeram@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-11-14 05:31:51 +0000 |
commit | 6dcd2576b1fa59d3b5cdbc462ccad39a447c2985 (patch) | |
tree | 69cd8c808a971e62cde8d82ab4d3cca0dce331c2 /chrome/common | |
parent | 3f005c228392762826a6ab1aaafe6dd31d31518d (diff) | |
download | chromium_src-6dcd2576b1fa59d3b5cdbc462ccad39a447c2985.zip chromium_src-6dcd2576b1fa59d3b5cdbc462ccad39a447c2985.tar.gz chromium_src-6dcd2576b1fa59d3b5cdbc462ccad39a447c2985.tar.bz2 |
Send match type for Instant extended mode.
Also:
+ Remove deprecated SetPreviewHeight().
+ Rename contents to description.
+ Remove is_search. We don't support non-URL entries in the native
(restricted) autocomplete results.
+ Other cosmetic changes.
BUG=159740
R=sky@chromium.org,dcblack@chromium.org,jschuh@chromium.org
TEST=none; no change in functionality.
Review URL: https://chromiumcodereview.appspot.com/11312175
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167607 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r-- | chrome/common/instant_types.cc | 4 | ||||
-rw-r--r-- | chrome/common/instant_types.h | 18 | ||||
-rw-r--r-- | chrome/common/render_messages.h | 4 |
3 files changed, 11 insertions, 15 deletions
diff --git a/chrome/common/instant_types.cc b/chrome/common/instant_types.cc index cf50e1c..86b4461 100644 --- a/chrome/common/instant_types.cc +++ b/chrome/common/instant_types.cc @@ -20,9 +20,7 @@ InstantSuggestion::InstantSuggestion(const string16& in_text, InstantSuggestion::~InstantSuggestion() { } -InstantAutocompleteResult::InstantAutocompleteResult() - : is_search(false), - relevance(0) { +InstantAutocompleteResult::InstantAutocompleteResult() : relevance(0) { } InstantAutocompleteResult::~InstantAutocompleteResult() { diff --git a/chrome/common/instant_types.h b/chrome/common/instant_types.h index ed075b06..627a565 100644 --- a/chrome/common/instant_types.h +++ b/chrome/common/instant_types.h @@ -49,21 +49,19 @@ struct InstantAutocompleteResult { InstantAutocompleteResult(); ~InstantAutocompleteResult(); - // The provider name. May be empty. + // The provider name, as returned by AutocompleteProvider::GetName(). string16 provider; - // True iff this is a search suggestion. - bool is_search; + // The type of the result, as returned by AutocompleteMatch::TypeToString(). + string16 type; - // The title of the match. - string16 contents; + // The description (title), same as AutocompleteMatch::description. + string16 description; - // The URL of the match. - // TODO(dhollowa): Remove this once the privacy story is sorted out. - GURL destination_url; + // The URL of the match, same as AutocompleteMatch::destination_url. + string16 destination_url; - // The relevance score of this match. Same as the relevance score stored in - // AutocompleteMatch. + // The relevance score of this match, same as AutocompleteMatch::relevance. int relevance; }; diff --git a/chrome/common/render_messages.h b/chrome/common/render_messages.h index 79b051e..8953ef0 100644 --- a/chrome/common/render_messages.h +++ b/chrome/common/render_messages.h @@ -156,8 +156,8 @@ IPC_STRUCT_TRAITS_END() IPC_STRUCT_TRAITS_BEGIN(InstantAutocompleteResult) IPC_STRUCT_TRAITS_MEMBER(provider) - IPC_STRUCT_TRAITS_MEMBER(is_search) - IPC_STRUCT_TRAITS_MEMBER(contents) + IPC_STRUCT_TRAITS_MEMBER(type) + IPC_STRUCT_TRAITS_MEMBER(description) IPC_STRUCT_TRAITS_MEMBER(destination_url) IPC_STRUCT_TRAITS_MEMBER(relevance) IPC_STRUCT_TRAITS_END() |