diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 18:06:44 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-08 18:06:44 +0000 |
commit | 78994ab0a043ead9b3edb4a48c7f13cc6c2aede6 (patch) | |
tree | 357ae4e0cf8bf140e616d3086b29472043aaf0e5 /chrome/common | |
parent | a7a265efd24072f9dc7b5f737ec84d5ae0553cd6 (diff) | |
download | chromium_src-78994ab0a043ead9b3edb4a48c7f13cc6c2aede6.zip chromium_src-78994ab0a043ead9b3edb4a48c7f13cc6c2aede6.tar.gz chromium_src-78994ab0a043ead9b3edb4a48c7f13cc6c2aede6.tar.bz2 |
Add the "virtual" keyword on method overrides that are missing it.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5648004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r-- | chrome/common/json_value_serializer.h | 12 | ||||
-rw-r--r-- | chrome/common/net/gaia/gaia_auth_fetcher.h | 12 | ||||
-rw-r--r-- | chrome/common/security_filter_peer.h | 8 |
3 files changed, 16 insertions, 16 deletions
diff --git a/chrome/common/json_value_serializer.h b/chrome/common/json_value_serializer.h index 11b7b7a..e0c9569 100644 --- a/chrome/common/json_value_serializer.h +++ b/chrome/common/json_value_serializer.h @@ -33,12 +33,12 @@ class JSONStringValueSerializer : public ValueSerializer { allow_trailing_comma_(false) { } - ~JSONStringValueSerializer(); + virtual ~JSONStringValueSerializer(); // Attempt to serialize the data structure represented by Value into // JSON. If the return value is true, the result will have been written // into the string passed into the constructor. - bool Serialize(const Value& root); + virtual bool Serialize(const Value& root); // Attempt to deserialize the data structure encoded in the string passed // in to the constructor into a structure of Value objects. If the return @@ -47,7 +47,7 @@ class JSONStringValueSerializer : public ValueSerializer { // If |error_message| is non-null, it will be filled in with a formatted // error message including the location of the error if appropriate. // The caller takes ownership of the returned value. - Value* Deserialize(int* error_code, std::string* error_message); + virtual Value* Deserialize(int* error_code, std::string* error_message); void set_pretty_print(bool new_value) { pretty_print_ = new_value; } bool pretty_print() { return pretty_print_; } @@ -75,7 +75,7 @@ class JSONFileValueSerializer : public ValueSerializer { explicit JSONFileValueSerializer(const FilePath& json_file_path) : json_file_path_(json_file_path) {} - ~JSONFileValueSerializer() {} + virtual ~JSONFileValueSerializer() {} // DO NOT USE except in unit tests to verify the file was written properly. // We should never serialize directly to a file since this will block the @@ -85,7 +85,7 @@ class JSONFileValueSerializer : public ValueSerializer { // Attempt to serialize the data structure represented by Value into // JSON. If the return value is true, the result will have been written // into the file whose name was passed into the constructor. - bool Serialize(const Value& root); + virtual bool Serialize(const Value& root); // Attempt to deserialize the data structure encoded in the file passed // in to the constructor into a structure of Value objects. If the return @@ -94,7 +94,7 @@ class JSONFileValueSerializer : public ValueSerializer { // If |error_message| is non-null, it will be filled in with a formatted // error message including the location of the error if appropriate. // The caller takes ownership of the returned value. - Value* Deserialize(int* error_code, std::string* error_message); + virtual Value* Deserialize(int* error_code, std::string* error_message); // This enum is designed to safely overlap with JSONReader::JsonParseError. enum JsonFileError { diff --git a/chrome/common/net/gaia/gaia_auth_fetcher.h b/chrome/common/net/gaia/gaia_auth_fetcher.h index e0fe76e..1a1602d 100644 --- a/chrome/common/net/gaia/gaia_auth_fetcher.h +++ b/chrome/common/net/gaia/gaia_auth_fetcher.h @@ -74,12 +74,12 @@ class GaiaAuthFetcher : public URLFetcher::Delegate { const std::string& info_key); // Implementation of URLFetcher::Delegate - void OnURLFetchComplete(const URLFetcher* source, - const GURL& url, - const URLRequestStatus& status, - int response_code, - const ResponseCookies& cookies, - const std::string& data); + virtual void OnURLFetchComplete(const URLFetcher* source, + const GURL& url, + const URLRequestStatus& status, + int response_code, + const ResponseCookies& cookies, + const std::string& data); // StartClientLogin been called && results not back yet? bool HasPendingFetch(); diff --git a/chrome/common/security_filter_peer.h b/chrome/common/security_filter_peer.h index 2559bf3..e82f748 100644 --- a/chrome/common/security_filter_peer.h +++ b/chrome/common/security_filter_peer.h @@ -110,10 +110,10 @@ class ReplaceContentPeer : public SecurityFilterPeer { virtual void OnReceivedResponse( const webkit_glue::ResourceResponseInfo& info, bool content_filtered); - void OnReceivedData(const char* data, int len); - void OnCompletedRequest(const URLRequestStatus& status, - const std::string& security_info, - const base::Time& completion_time); + virtual void OnReceivedData(const char* data, int len); + virtual void OnCompletedRequest(const URLRequestStatus& status, + const std::string& security_info, + const base::Time& completion_time); private: webkit_glue::ResourceResponseInfo response_info_; |