diff options
| author | tbarzic@chromium.org <tbarzic@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-25 01:42:57 +0000 |
|---|---|---|
| committer | tbarzic@chromium.org <tbarzic@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-01-25 01:42:57 +0000 |
| commit | a504ba7dfbcbc6b1d726cead0020aec7d526ba99 (patch) | |
| tree | 4c739837311972aa4162898bf4c0d12baef618a2 /chrome/common | |
| parent | e28d1f29805fcc1df5113c02068fea705e171c30 (diff) | |
| download | chromium_src-a504ba7dfbcbc6b1d726cead0020aec7d526ba99.zip chromium_src-a504ba7dfbcbc6b1d726cead0020aec7d526ba99.tar.gz chromium_src-a504ba7dfbcbc6b1d726cead0020aec7d526ba99.tar.bz2 | |
[ChromeOS-HTerm] Use pseudo-terminal instead of pipes to communicate with crosh process.
Some applications we run in crosh expect their stdin/stdout to be terminal, and
malfunction if we use pipes.
One of results of this change is we stopped distinguishing between stdout and
stderr (both streams are detected through same file descriptor). I still have to
update extension API to reflect this.
Also, added support for detecting when crosh process exits.
This depends on https://chromiumcodereview.appspot.com/9150051/ and
https://chromiumcodereview.appspot.com/9176013/ (and I tested it with those two in place).
TEST=ExtensionTerminalPrivateApiTest.*, ProcessProxy.*, git try
BUG=chromium-os:23273
Review URL: https://chromiumcodereview.appspot.com/9195039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118975 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
| -rw-r--r-- | chrome/common/extensions/api/terminalPrivate.json | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chrome/common/extensions/api/terminalPrivate.json b/chrome/common/extensions/api/terminalPrivate.json index 5d99beb..42107e7 100644 --- a/chrome/common/extensions/api/terminalPrivate.json +++ b/chrome/common/extensions/api/terminalPrivate.json @@ -98,8 +98,8 @@ { "name": "type", "type": "string", - "description": "Type of the output stream from which output came.", - "enum": ["stdout", "stderr"] + "description": "Type of the output stream from which output came. When process exits, output type will be set to exit", + "enum": ["stdout", "stderr", "exit"] }, { "name": "text", |