diff options
author | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-07 23:07:27 +0000 |
---|---|---|
committer | erg@google.com <erg@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | 2010-12-07 23:07:27 +0000 |
commit | aa20e0622a945f94958daa1940385c29779d09e4 (patch) | |
tree | 79ba5e11afb6d6edc5a9e4edef95cca4f86467de /chrome/common | |
parent | 111ca63cacf4cedb65be41fd4cabfa5ad7bb6b86 (diff) | |
download | chromium_src-aa20e0622a945f94958daa1940385c29779d09e4.zip chromium_src-aa20e0622a945f94958daa1940385c29779d09e4.tar.gz chromium_src-aa20e0622a945f94958daa1940385c29779d09e4.tar.bz2 |
Move more code from headers to implementation.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/5624002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68534 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/common')
-rw-r--r-- | chrome/common/json_schema_validator.cc | 1 | ||||
-rw-r--r-- | chrome/common/json_schema_validator.h | 2 | ||||
-rw-r--r-- | chrome/common/metrics_helpers.cc | 4 | ||||
-rw-r--r-- | chrome/common/metrics_helpers.h | 4 |
4 files changed, 9 insertions, 2 deletions
diff --git a/chrome/common/json_schema_validator.cc b/chrome/common/json_schema_validator.cc index ee28a89..a76b2d9 100644 --- a/chrome/common/json_schema_validator.cc +++ b/chrome/common/json_schema_validator.cc @@ -159,6 +159,7 @@ JSONSchemaValidator::JSONSchemaValidator(DictionaryValue* schema, } } +JSONSchemaValidator::~JSONSchemaValidator() {} bool JSONSchemaValidator::Validate(Value* instance) { errors_.clear(); diff --git a/chrome/common/json_schema_validator.h b/chrome/common/json_schema_validator.h index 9af31fb..68030f8 100644 --- a/chrome/common/json_schema_validator.h +++ b/chrome/common/json_schema_validator.h @@ -113,6 +113,8 @@ class JSONSchemaValidator { // not be used with untrusted schemas. JSONSchemaValidator(DictionaryValue* schema, ListValue* types); + ~JSONSchemaValidator(); + // Whether the validator allows additional items for objects and lists, beyond // those defined by their schema, by default. // diff --git a/chrome/common/metrics_helpers.cc b/chrome/common/metrics_helpers.cc index 6462383..7296ce1 100644 --- a/chrome/common/metrics_helpers.cc +++ b/chrome/common/metrics_helpers.cc @@ -499,6 +499,10 @@ void MetricsServiceBase::SnapshotProblemResolved(int amount) { std::abs(amount)); } +HistogramSender::HistogramSender() {} + +HistogramSender::~HistogramSender() {} + void HistogramSender::TransmitAllHistograms(Histogram::Flags flag_to_set, bool send_only_uma) { StatisticsRecorder::Histograms histograms; diff --git a/chrome/common/metrics_helpers.h b/chrome/common/metrics_helpers.h index b261488..bd18b88 100644 --- a/chrome/common/metrics_helpers.h +++ b/chrome/common/metrics_helpers.h @@ -185,8 +185,8 @@ class MetricsLogBase { // onward. class HistogramSender { protected: - HistogramSender() {} - virtual ~HistogramSender() {} + HistogramSender(); + virtual ~HistogramSender(); // Snapshot all histograms, and transmit the delta. // The arguments allow a derived class to select only a subset for |