diff options
| author | rvargas <rvargas@chromium.org> | 2014-12-03 14:24:06 -0800 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2014-12-03 22:24:46 +0000 |
| commit | 6b687a5e232c80539772dc3dbe35b98095064c38 (patch) | |
| tree | 152e59d10d89943e7ec0363b8f686b483c9d31be /chrome/installer/gcapi | |
| parent | e77e1c6d3ecf6398fdbd32fd262e6d6d5e00c4bd (diff) | |
| download | chromium_src-6b687a5e232c80539772dc3dbe35b98095064c38.zip chromium_src-6b687a5e232c80539772dc3dbe35b98095064c38.tar.gz chromium_src-6b687a5e232c80539772dc3dbe35b98095064c38.tar.bz2 | |
Upgrade the windows specific version of LaunchProcess to avoid raw handles.
This change implies that extensions::LaunchNativeProcess also changes to
return base::Process, and that requires base::EnsureProcessTerminated to
deal with base:Process (as it basically claims ownership of the process).
This CL fixes some leaks all around.
BUG=417532
Review URL: https://codereview.chromium.org/759903002
Cr-Commit-Position: refs/heads/master@{#306687}
Diffstat (limited to 'chrome/installer/gcapi')
| -rw-r--r-- | chrome/installer/gcapi/gcapi.cc | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/chrome/installer/gcapi/gcapi.cc b/chrome/installer/gcapi/gcapi.cc index ce03d85..f08d90f 100644 --- a/chrome/installer/gcapi/gcapi.cc +++ b/chrome/installer/gcapi/gcapi.cc @@ -519,8 +519,7 @@ BOOL __stdcall LaunchGoogleChrome() { // Couldn't get Omaha's process launcher, Omaha may not be installed at // system level. Try just running Chrome instead. ret = base::LaunchProcess(chrome_command.GetCommandLineString(), - base::LaunchOptions(), - NULL); + base::LaunchOptions()).IsValid(); } if (impersonation_success) |