diff options
| author | blundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-23 17:28:26 +0000 |
|---|---|---|
| committer | blundell@chromium.org <blundell@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2014-01-23 17:28:26 +0000 |
| commit | 13d13832b62ba18de11342d299444ceaf1268d75 (patch) | |
| tree | 3bb743e15423b64517cf09b8ecab59129a2a498c /chrome/installer/mini_installer.gyp | |
| parent | 0d61bf70784a4b3415758304b60a84a3afa70ecf (diff) | |
| download | chromium_src-13d13832b62ba18de11342d299444ceaf1268d75.zip chromium_src-13d13832b62ba18de11342d299444ceaf1268d75.tar.gz chromium_src-13d13832b62ba18de11342d299444ceaf1268d75.tar.bz2 | |
Remove all unsafe usage of FakeSigninManagerBase.
Several cross-platform tests were supplying FakeSigninManagerBase::Build() as
the build function for SigninManagerFactory. This is unsafe, as on all
platforms other than ChromeOS SigninManagerFactory::GetForProfile() returns a
SigninManager* (which has an expanded public API over SigninManagerBase). This
CL changes FakeSigninManagerBase::Build() to create a FakeSigninManagerBase on
ChromeOS and a FakeSigninManager on all other platforms (similar to the way
that SigninManagerFactory::GetForProfile() works). It changes all clients to
use FakeSigninManagerBase::Build().
TBR=zea
Review URL: https://codereview.chromium.org/136533003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246631 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/mini_installer.gyp')
0 files changed, 0 insertions, 0 deletions