diff options
| author | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-07 04:08:56 +0000 |
|---|---|---|
| committer | gab@chromium.org <gab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | 2012-05-07 04:08:56 +0000 |
| commit | 58d9fe56a31875c85168c8b7264099900ea397b5 (patch) | |
| tree | 7e18a793e6692199e5338b54cf5c6f89bec18d17 /chrome/installer/setup/setup_constants.h | |
| parent | fe4e649c161fc4e637fe963d15c904ee5e2e1bc7 (diff) | |
| download | chromium_src-58d9fe56a31875c85168c8b7264099900ea397b5.zip chromium_src-58d9fe56a31875c85168c8b7264099900ea397b5.tar.gz chromium_src-58d9fe56a31875c85168c8b7264099900ea397b5.tar.bz2 | |
1) Generate VisualElementsManifest.xml at install time from a pre-defined template.
This allows us to put images in the version directory (i.e. a path that changes each istall; rather than needing the images beside chrome.exe).
This also allows us to localize the Display Name of Google Chrome. This however does not fix bug #123376 (we have the same issue here).
2) Fixes create_installer_archive.py to not create empty directories for output directories specified in chrome.release for which the input is not present when packaging chrome.7z
3) Removes "Dictionaries\en-US.bdic: %(ChromeDir)s\Dictionaries" from chrome.release which has not been packaged since Chrome 17 (and maybe even before that).
4) (2+3) have the side-effect that there is no longer an empty Dictionaries/ directory created at install.
BUG=123319,123376
TEST=Install Chrome on Win8 and watch VisualElementsManifest.xml land with the correct values.
Overinstall Chrome on a Win8 install with VisualElementsManifest.xml from an installer that doesn't have VisualElements --> ensure VisualElementsManifest.xml is deleted and icons go back to default-style.
Review URL: http://codereview.chromium.org/10160011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135615 0039d316-1c4b-4281-b951-d872f2087c98
Diffstat (limited to 'chrome/installer/setup/setup_constants.h')
| -rw-r--r-- | chrome/installer/setup/setup_constants.h | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/chrome/installer/setup/setup_constants.h b/chrome/installer/setup/setup_constants.h index aa15381..0c17223 100644 --- a/chrome/installer/setup/setup_constants.h +++ b/chrome/installer/setup/setup_constants.h @@ -1,4 +1,4 @@ -// Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. +// Copyright (c) 2012 The Chromium Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. @@ -10,15 +10,17 @@ namespace installer { -extern const wchar_t kWowHelperExe[]; -extern const wchar_t kDictionaries[]; extern const wchar_t kChromeArchive[]; extern const wchar_t kChromeCompressedArchive[]; +extern const wchar_t kVisualElements[]; +extern const wchar_t kVisualElementsManifest[]; +extern const wchar_t kWowHelperExe[]; extern const wchar_t kInstallSourceDir[]; extern const wchar_t kInstallSourceChromeDir[]; extern const wchar_t kMediaPlayerRegPath[]; + } // namespace installer #endif // CHROME_INSTALLER_SETUP_SETUP_CONSTANTS_H__ |