diff options
author | brettw <brettw@chromium.org> | 2015-07-14 15:42:19 -0700 |
---|---|---|
committer | Commit bot <commit-bot@chromium.org> | 2015-07-14 22:43:54 +0000 |
commit | 0eabfa001ba06d3c66992b95b69a988ef0633992 (patch) | |
tree | a62a2b2c2e828f99ac192c41048e247fb0aa32da /chrome/installer/setup | |
parent | 28c7c11feb94dc2593e5a4bf2b7aeb9d15bd0e49 (diff) | |
download | chromium_src-0eabfa001ba06d3c66992b95b69a988ef0633992.zip chromium_src-0eabfa001ba06d3c66992b95b69a988ef0633992.tar.gz chromium_src-0eabfa001ba06d3c66992b95b69a988ef0633992.tar.bz2 |
Move JoinString to the base namespace.
Change "Separator" from string to StringPIece (most are constants). Remove char versions for symmetry with SplitString.
Update callers who pass empty separators to use a base::StringPiece()
Change chromecast/base/metrics/cast_metrics_helper.cc to not use JoinString at all and just append to the output (code is simpler and faster).
TBR=zelidrag@chromium.org for chromeos
Review URL: https://codereview.chromium.org/1223153003
Cr-Commit-Position: refs/heads/master@{#338762}
Diffstat (limited to 'chrome/installer/setup')
-rw-r--r-- | chrome/installer/setup/update_active_setup_version_work_item.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chrome/installer/setup/update_active_setup_version_work_item.cc b/chrome/installer/setup/update_active_setup_version_work_item.cc index 4d35494..7372675 100644 --- a/chrome/installer/setup/update_active_setup_version_work_item.cc +++ b/chrome/installer/setup/update_active_setup_version_work_item.cc @@ -69,5 +69,5 @@ base::string16 UpdateActiveSetupVersionWorkItem::GetUpdatedActiveSetupVersion( version_components[OS_UPGRADES] = base::UintToString16(previous_value + 1); } - return JoinString(version_components, L','); + return base::JoinString(version_components, L","); } |