diff options
| author | gab <gab@chromium.org> | 2015-08-06 14:34:17 -0700 |
|---|---|---|
| committer | Commit bot <commit-bot@chromium.org> | 2015-08-06 21:34:39 +0000 |
| commit | c9be7d5e6357d0a94776304294d48e662083e808 (patch) | |
| tree | 8609f59e3656870ee95ac77b5f7fbafeb2e63d4b /chrome/installer/setup | |
| parent | f29d63044b606b5e4236145e3e58ce709925eb21 (diff) | |
| download | chromium_src-c9be7d5e6357d0a94776304294d48e662083e808.zip chromium_src-c9be7d5e6357d0a94776304294d48e662083e808.tar.gz chromium_src-c9be7d5e6357d0a94776304294d48e662083e808.tar.bz2 | |
Fix Active Setup uninstall documentation.
In the early days of using Active Setup in Chrome the idea was to up the
Active Setup Version with Chrome's version, but we realized there was no
point and we never actually did that... The documentation in uninstall.cc
however still referred to that approach, updated to reflect the truth.
BUG=None
Review URL: https://codereview.chromium.org/1281523006
Cr-Commit-Position: refs/heads/master@{#342202}
Diffstat (limited to 'chrome/installer/setup')
| -rw-r--r-- | chrome/installer/setup/uninstall.cc | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/chrome/installer/setup/uninstall.cc b/chrome/installer/setup/uninstall.cc index 51799bb..4049a46 100644 --- a/chrome/installer/setup/uninstall.cc +++ b/chrome/installer/setup/uninstall.cc @@ -728,13 +728,12 @@ void UninstallActiveSetupEntries(const InstallerState& installer_state, // Windows leaves keys behind in HKCU\\Software\\(Wow6432Node\\)?Microsoft\\ // Active Setup\\Installed Components\\{guid} - // for every user that logged in since system-level Chrome was installed. - // This is a problem because Windows compares the value of the Version subkey - // in there with the value of the Version subkey in the matching HKLM entries - // before running Chrome's Active Setup so if Chrome was to be reinstalled - // with a lesser version (e.g. switching back to a more stable channel), the - // affected users would not have Chrome's Active Setup called until Chrome - // eventually updated passed that user's registered Version. + // for every user that logged in since system-level Chrome was installed. This + // is a problem because Windows compares the value of the Version subkey in + // there with the value of the Version subkey in the matching HKLM entries + // before running Chrome's Active Setup so if Chrome was to be + // uninstalled/reinstalled by an admin, some users may not go through Active + // Setup again as desired. // // It is however very hard to delete those values as the registry hives for // other users are not loaded by default under HKEY_USERS (unless a user is |